1194509 - [Keyboard] Numpad keyboard displays no divider between '0' and left adjacent key [New Passcode, SIM Pin]

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Oliver Nelson [:oliverthor]]

Attachment: 2015-08-13-17-29-47.png

Description:
When the user is entering a new passcode for their device (within Settings) or is unlocking their SIM after rebooting their device, they will observe the numpad keyboard displays no divider/separator between the '0' and it's adjacent left key, giving the appearance of one large '0' key. Tapping this far left 'key' with no bounds will highlight the button for the space it occupies, but does not contain boundaries for it's right border.


Repro Steps:
1) Update a Aries to 20150812231434
2) Open the Settings app
3) Open 'Screen Lock'
4) Tap 'change passcode'
5) Observe keyboard

Actual:
Keyboard displays no divider between '0' and left adjacent key

Expected:
Keyboard displays a separator between '0' and empty left adjacent key


Environmental Variables:
-------------------------------

Device: Aries Master
Build ID: 20150812231434
Gaia: 52f3ea58df38e5427f6afeb636bc6ad01d24022f
Gecko: 7649ffe28b67aa2dad0f67ea01500c0ff91b2bac
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (Master)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Flame Master
BuildID: 20150813030210
Gaia: 52f3ea58df38e5427f6afeb636bc6ad01d24022f
Gecko: 7649ffe28b67aa2dad0f67ea01500c0ff91b2bac
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (Master) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0
***************************

Issue DOES NOT REPRODUCE on 2.2 for flame devices
Results: Divider is visible between '0' and left adjacent key

Device: Flame 2.2
BuildID: 20150812032504
Gaia: 102f1299e9eafe3760e1deb44d556b5c4f36b5af
Gecko: 9295034c0ee3
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
-------------------------------

Repro frequency: 5/5
See attached: 
screenshot

Comment 1

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Noticeable regression.

Requesting a window.

Comment 2

[Martin Shuman [:Marty]]

This issue appears to be caused by:
Bug 1192117 - Layouts with `secondLayout` does not labelled correctly

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 2.5
BuildID: 20150810163435
Gaia: 84fc50c0b4da86de68ed82022b5f05c9968da0e5
Gecko: 84fb29517667
Version: 43.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

First Broken 
Environmental Variables:
Device: Flame 2.5
BuildID: 20150810232235
Gaia: 7034cac920c39ecf8f3e248a7bc3b20a088b808d
Gecko: 4d8909d984ce
Version: 43.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Last Working gaia / First Broken gecko -  Issue does NOT reproduce
Gaia: 84fc50c0b4da86de68ed82022b5f05c9968da0e5
Gecko: 4d8909d984ce

First Broken gaia / Last Working gecko - Issue DOES reproduce
Gaia: 7034cac920c39ecf8f3e248a7bc3b20a088b808d
Gecko: 84fb29517667

Gaia Pushlog:
https://github.com/mozilla-b2g/gaia/compare/84fc50c0b4da86de68ed82022b5f05c9968da0e5...7034cac920c39ecf8f3e248a7bc3b20a088b808d

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

Timothy, can you take a look at this please? This might have been caused by the landing for bug 1192117.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thanks for spotting that.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] timdream:keyboard-lowercase3 > mozilla-b2g:master

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8648593 [details] [review]
[gaia] timdream:keyboard-lowercase3 > mozilla-b2g:master

The border line was lost because there is no <span key-element> to show. This patch makes KeyView construct that regardless.

Comment 7

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 8648593 [details] [review]
[gaia] timdream:keyboard-lowercase3 > mozilla-b2g:master

Solves the problem against master, checked a few non-Latin keyboards and English to see visually weird things, but all looks ok.

r=me.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/370c1bcf726f9ed3cabe8ce84e61998a5fa0e141

Comment 9

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: Keyboard displays a separator between '0' and empty left adjacent key as expected.
See attachment: verified_FlameKK_v2.5.png
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150819030215
Gaia Revision          1e1197e0e8e64307aa382ffba4711d1c661de7ca
Gaia Date              2015-08-18 16:54:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f384789a29dcfd514d25d4a16a97ec5309612d78
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150819.063618
Firmware Date          Wed Aug 19 06:36:31 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150820005800
Gaia Revision          89e0096a3de0378e3eda77e6a2a0bb5ca03eb8bb
Gaia Date              2015-08-19 18:28:14
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/29b2df16e961fbe9a379362ecba6f888d1754bc3
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150820.002839
Firmware Date          Thu Aug 20 00:28:46 UTC 2015
Bootloader             s1

Comment 10

[Shally Li（leave from Mozilla）]

Attachment: verified_FlameKK_v2.5.png