1194547 - [Window Mgmt] Taking a picture from galley in landscape and going back to gallery causes the device lock up

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

If the user opens gallery while in landscape mode, taps on the "Camera" icon, snaps a picture, taps on the preview and goes back to gallery, the device will stop responding to touch inputs. The user must hold device in landscape mode the whole time to reproduce this issue. 


Prerequisite: All steps below are performed while holding the device in landscape mode. 

Repro Steps:
1) Update a Aries to 20150813030210
2) Open the gallery app while in landscape mode.
3) Tap on the "Camera" icon in gallery. 
4) Take a picture and tap on the preview circle. 
5) Tap on the "..." and then tap on "Open Gallery". 
6) Try to tap on a picture to view it. 

Actual:
The phone will start acting strangely and will not respond to touch input.

Expected:
The phone responds to the user's touch inputs. 

Notes:

Device: Aries (RC4 > OTA to dogfood-latest)
BuildID: 20150812231434
Gaia: 52f3ea58df38e5427f6afeb636bc6ad01d24022f
Gecko: 7649ffe28b67aa2dad0f67ea01500c0ff91b2bac
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5 Master) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

User Impact:

Repro frequency: 5/5 100%
See attached: Video, logcat

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

Regression and locks up the user's device so nominating 2.5?

Please note this is not the same issue as bug 1192759 This bug goes back before what the regression window points to listed in that issue. That issue is only dealing with the zoomed in gallery view.

Comment 2

[Peter Bylenga [:PBylenga]]

Nominating to block dogfood ota as it freezes the app.

NI Doug for feedback on blocking ota.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

It wasn't mentioned anywhere but this issue does repro on Flame 2.5.

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: GalleryCameraLockup.txt

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue also occurs on Flame Master

The phone stops responding to touch input after performing the steps from Comment 0. 

Device: Flame 2.5 (Full Flash)(KK)(319mb)
Build ID: 20150814030213
Gaia: 39b121515ab8a8c3ea07f26d3ba1dd792e90217c
Gecko: 4e883591bb5dff021c108d3e30198a99547eed1e
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0


This issue does not occur on Flame 2.2

Touch inputs work as expected after completing steps from Comment 0.

Device: Flame 2.2 (Full Flash)(KK)(319mb)
Build ID: 20150814032503
Gaia: 102f1299e9eafe3760e1deb44d556b5c4f36b5af
Gecko: 9295034c0ee3
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working
Device: Flame
BuildID: 20150618012742
Gaia: ad8a87ddd3d255f34f5f58893010ddbaf5fa0d72
Gecko: bd7b2334924d
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 41.0a1 (2.5 Master) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

First Broken
Device: Flame
BuildID: 20150618025743
Gaia: 7626a37ee5e4ec63a5f383897b5226f7b14135ae
Gecko: 148608189b11
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 41.0a1 (2.5 Master) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Last Working Gaia First Broken Gecko - no repro
Gaia: ad8a87ddd3d255f34f5f58893010ddbaf5fa0d72
Gecko: 148608189b11

Last Working Gecko First Broken Gaia - repro
Gaia: 7626a37ee5e4ec63a5f383897b5226f7b14135ae
Gecko: bd7b2334924d

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/ad8a87ddd3d255f34f5f58893010ddbaf5fa0d72...7626a37ee5e4ec63a5f383897b5226f7b14135ae

Caused by changes made in Bug 1170944.

Comment 7

[Peter Bylenga [:PBylenga]]

Given the length of the window, this isn't something new, removing dogfood-blocking tag.

Comment 8

[KTucker [:KTucker][Inactive 3/4/2016]]

Alison, can you take a look at this please? This might have been caused by the landing for bug 1170944. The author of the original landing is no longer available.

Comment 9

[Alison Shiue]

Hi Fred,

Could you please help to dispatch this issue? Thank you!

Comment 10

[[e-mail]]

Luke, would you like take it a look?

Comment 11

[Luke Chang [:lchang] (inactive)]

After a quick look, I think it's caused by some racing condition and results in that the incorrect "overlay" class remains on the AppWindow.

I can look into it until next week as I have some other issues in hand. Keep the NI for a reminder. Please feel free to take this bug if anyone is interested in it.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: 2015-08-19-10-45-15.png

I can produce this bug very easily and I suspect this is not about Window Mgmt.

1. Go to Settings > Keyboards
2. Rotate the phone horizontally and tap "Built-in Keyboard" to go to the keyboard app settings.

Expected:

1. A horizontal keyboard settings app, response interaction.

Actual:

1. Content got enlarged with width === height of the device. Can't be interacted. See screenshot.

Going to move this to Core::Layout since there is no way window mgmt can enlarge the content (w/o some transfrom scale styling, which we don't do).

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (slow response; please ni? to queue) from comment #12)
> Going to move this to Core::Layout since there is no way window mgmt can
> enlarge the content (w/o some transfrom scale styling, which we don't do).

Actually, I am not sure about it, and I am not sure if this bug or bug 1192759 is talking about this STR. Let me comment there and let :etienne to respond.

Comment 15

[Etienne Segonzac (:etienne)]

Definitely something wrong with the screenshot here, taking a look.

Comment 16

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1194547 > mozilla-b2g:master

Comment 17

[Etienne Segonzac (:etienne)]

Comment on attachment 8652386 [details] [review]
[gaia] etiennesegonzac:bug-1194547 > mozilla-b2g:master

Hey Alberto, welcome to the wonderful world of window manager screenshots :)

Tried to explain what I changed in the commit message.
The main part if that anybody calling .ready() on an appWindow could lock it with the screenshot displayed.
This happened while resizing for example, hence this bug.

I verified that this patch does not regress neither bug 976846 nor bug 1072779, some of those old solutions just weren't applicable anymore.

Comment 18

[Alberto Pastor [:albertopq]]

Comment on attachment 8652386 [details] [review]
[gaia] etiennesegonzac:bug-1194547 > mozilla-b2g:master

I can still repro the bug described in comment #0. After going to the camera from the gallery, and opening the taken picture from preview on the gallery (everything in landscape mode) the pictures are not responding to clicks anymore. Any idea?

Comment 19

[Etienne Segonzac (:etienne)]

Comment on attachment 8652386 [details] [review]
[gaia] etiennesegonzac:bug-1194547 > mozilla-b2g:master

Thanks for diving into this Alberto!

Rebased my patch this morning, got a green try, replied to your comment on github and I can't reproduce Comment 0.

So asking for review again :)

Comment 20

[Alberto Pastor [:albertopq]]

Comment on attachment 8652386 [details] [review]
[gaia] etiennesegonzac:bug-1194547 > mozilla-b2g:master

Something was wrong with my device. I was having issues even on master when opening directly the Gallery in landscape mode. Everything worked fine after reflashing and pushing again your patch. Thanks!

Comment 22

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/73b3e382220adc2334ed043138bff2bd5578b1e3

Comment 23

[KTucker [:KTucker][Inactive 3/4/2016]]

Adding qawanted for verification.

Comment 24

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified fixed. After step 6, Gallery app can be utilized as expected.

Verified on:
Device: Flame 2.5
BuildID: 20150828030207
Gaia: b69c16798ddd7154207f56d983721a327522f5d1
Gecko: 87e23922be375985d0b1906ed5ba5f095f323a38
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Aries 2.5
BuildID: 20150828140025
Gaia: fa15462b29258fdec8329bfc367e590022dbc9e5
Gecko: 008d4d76f387b722fbee151e1c9e1501482054e5
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0