1194565 - Reset fails w/ 500 on zone URL changes

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: BrowserCompat, defect)

Description

[John Whitlock [:jwhitlock]]

What did you do?
================
1. Go to https://browsercompat.herokuapp.com/importer/6247 (the importer page for https://developer.mozilla.org/en-US/docs/Web/Apps/Design/Patterns/Entry_sheet)
2. Click Reset
3. Get a 500 error

What happened?
==============
When fetching https://developer.mozilla.org/en-US/docs/Web/Apps/Design/Patterns/Entry_sheet$json, a 302 redirect to https://developer.mozilla.org/en-US/Apps/Design/Patterns/Entry_sheet$json is returned.  The importer only expects redirects for renames, which redirect to the page, not a $json URL.  An exception is raised.

What should have happened?
==========================
The importer should have another code path to handle redirects due to zone URL changes.

Is there anything else we should know?
======================================

Comment 1

[MDN Team (:mdn-dev)]

Commits pushed to 1194565_zone_urls at https://github.com/mdn/browsercompat

https://github.com/mdn/browsercompat/commit/9d25f967777bcd14daf1d4b02439a65737251660
bug 1194565 - Add retry to tools/import_mdn.py

Change tools/import_mdn.py to retry on network connection errors. This
makes is more robust against MDN server restarts.

https://github.com/mdn/browsercompat/commit/b5e68628aaf2869dd3b4e89452769e86946f7c00
fix bug 1194565 - Handle zone URL changes

If the URL is changed to a zone, then the meta fetch (url + '$json')
will redirect to the zone URL (new url + '$json').  Update the
FeaturePage URL and process the zone meta JSON.

Comment 2

[MDN Team (:mdn-dev)]

Commits pushed to 1194565_zone_urls at https://github.com/mdn/browsercompat

https://github.com/mdn/browsercompat/commit/9d25f967777bcd14daf1d4b02439a65737251660
bug 1194565 - Add retry to tools/import_mdn.py

https://github.com/mdn/browsercompat/commit/b5e68628aaf2869dd3b4e89452769e86946f7c00
fix bug 1194565 - Handle zone URL changes

Comment 3

[MDN Team (:mdn-dev)]

Commit pushed to 1194565_zone_urls at https://github.com/mdn/browsercompat

https://github.com/mdn/browsercompat/commit/f278269bbd1a91147078452e5ab4b9b36f936f70
bug 1194565 - Code cleanup

- Make sample meta more consistant with the sample feature
- Remove commented code
- Add stackoverflow reference for version regex

Comment 4

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mdn/browsercompat

https://github.com/mdn/browsercompat/commit/a10aa9d53bbb9edd3848ea1915308bbc890df548
bug 1194565 - Allow zone URLs

/docs/Web/Apps was relocated to /Apps. The importer was expecting all
URLS to start with https://developer.mozilla.org/en-US/docs/. This
changes the prefix to https://developer.mozilla.org/en-US/.

https://github.com/mdn/browsercompat/commit/9d25f967777bcd14daf1d4b02439a65737251660
bug 1194565 - Add retry to tools/import_mdn.py

https://github.com/mdn/browsercompat/commit/b5e68628aaf2869dd3b4e89452769e86946f7c00
fix bug 1194565 - Handle zone URL changes

https://github.com/mdn/browsercompat/commit/f278269bbd1a91147078452e5ab4b9b36f936f70
bug 1194565 - Code cleanup

https://github.com/mdn/browsercompat/commit/675e00f84590059c107a7582e8035b12f7425f2c
Merge pull request #37 from mdn/1194565_zone_urls

fix bug 1194565 and bug 1134584 - Importer issues