If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Rename RasterImage::RecoverFromLossOfFrames() to something more sensible

RESOLVED FIXED in Firefox 43

Status

()

Core
ImageLib
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: seth, Assigned: seth)

Tracking

unspecified
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
After bug 1194059, RecoverFromLossOfFrames() is called not only in response to a GPU reset, but also if a corrupt GIF fooled us into thinking an image wasn't animated when it really was.

We should rename it (and probably update the NS_WARNING that it prints) to better capture this dual role.
(Assignee)

Comment 1

2 years ago
Created attachment 8648306 [details] [diff] [review]
Rename RecoverFromLossOfFrames() to RecoverFromInvalidFrames() to better reflect its role

I renamed RecoverFromLossOfFrames() to RecoverFromInvalidFrames() and updated
the comment and the NS_WARNING message.
Attachment #8648306 - Flags: review?(tnikkel)
Attachment #8648306 - Flags: review?(tnikkel) → review+
(Assignee)

Comment 2

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d3dbbed86c6
https://hg.mozilla.org/mozilla-central/rev/8d3dbbed86c6
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.