1194683 - RollingFileLoggerTests causes infinite loop in RollingFileLogger:newLogWithDate

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Emily Toop (:fluffyemily)]

SharedTests.RollingFileLoggerTests testNewLogCreatesLogFileWithTimestamp

enters newLogWithDate and at line 44 enters infinite loop

 while sizeOfAllLogFiles() > sizeLimit {
            deleteOldestLog()
        }

deleteOldestLog() doesn't delete anything and so sizeOfAllLogFiles() is never < sizeLimit and the while loop is never exited.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: https://github.com/mozilla/firefox-ios/pull/934

Comment 2

[Stephan Leroux [:sleroux]]

Merged