RollingFileLoggerTests causes infinite loop in RollingFileLogger:newLogWithDate

RESOLVED FIXED

Status

()

Firefox for iOS
Build & Test
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: fluffyemily, Assigned: sleroux)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
SharedTests.RollingFileLoggerTests testNewLogCreatesLogFileWithTimestamp

enters newLogWithDate and at line 44 enters infinite loop

 while sizeOfAllLogFiles() > sizeLimit {
            deleteOldestLog()
        }

deleteOldestLog() doesn't delete anything and so sizeOfAllLogFiles() is never < sizeLimit and the while loop is never exited.
(Assignee)

Updated

2 years ago
Assignee: nobody → sleroux
(Assignee)

Comment 1

2 years ago
Created attachment 8648196 [details] [review]
https://github.com/mozilla/firefox-ios/pull/934
Attachment #8648196 - Flags: review?(rnewman)
Attachment #8648196 - Flags: review?(rnewman) → review+
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Merged
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
tracking-fxios: ? → ---
You need to log in before you can comment on or make changes to this bug.