1194685 - [Ubuntu] Several menus/submenus are black

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Reproducible on: Firefox 42.0a2 under Ubuntu


STR
1.Launch Firefox with clean profile.
2.Enter in Customize mode and enable the Menu Bar.
3.Click on the Menu items to open the submenus.

ER
The menus/submenus are white using Dev Edition theme.

AR
Several menus/submenus are black on the Dev Edition theme.
See screenshots:
http://i.imgur.com/0GNXDCY.png
http://i.imgur.com/SdZm3zk.png


Additional notes:
- This issue is reproducible on Firefox 42.0a2 (2015-08-13) using Ubuntu 14.04 32-bit.
- This issue does not reproduce on Windows and Mac.
- It is not reproducible in Firefox 40.0a2 (2015-05-12). 
- This issue is a regression.I will provide a regression window as soon as possible.

Comment 1

[:Gijs (he/him)]

Why do you think the menus should be white? It looks like we use the OS's styling. I expect this changed when we switched to GTK3.

Comment 2

[Brian Grinstead [:bgrins]]

Do you see the same menu styling with the Default theme applied?

Comment 3

[luniki]

I get this error with any theme.

Comment 4

[luniki]

Attachment: Menu_016.png

Comment 5

[luniki]

I am using Firefox Developer Edition 42.0a2 under Linux Mint 17 with awesome as window manager.

Comment 6

[:Gijs (he/him)]

(In reply to luniki from comment #5)
> I am using Firefox Developer Edition 42.0a2 under Linux Mint 17 with awesome
> as window manager.

Are other applications' menus (that use the awesome wm's theme) dark with light (grey/white) text by default?

(In reply to luniki from comment #3)
> I get this error with any theme.

Any Firefox theme, I assume you mean? Including the default?

Comment 7

[:Gijs (he/him)]

(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #0)
> - This issue is a regression.I will provide a regression window as soon as
> possible.

A regression window would still be really helpful.

Comment 8

[luniki]

After creating a .config/gtk-3.0/settings.ini with 

  [Settings]
  gtk-theme-name= Mint-X

it works again.

Comment 9

[luniki]

(In reply to :Gijs Kruitbosch from comment #6)
> Are other applications' menus (that use the awesome wm's theme) dark with
> light (grey/white) text by default?

No, there aren't other applications using awesome wm's theme (besides the launcher menu but that one uses a different dark color than seen in my screenshot).

> (In reply to luniki from comment #3)
> > I get this error with any theme.
> 
> Any Firefox theme, I assume you mean? Including the default?

Any FF theme including the default.

Comment 10

[:Gijs (he/him)]

(In reply to luniki from comment #9)
> (In reply to :Gijs Kruitbosch from comment #6)
> > Are other applications' menus (that use the awesome wm's theme) dark with
> > light (grey/white) text by default?
> 
> No, there aren't other applications using awesome wm's theme (besides the
> launcher menu but that one uses a different dark color than seen in my
> screenshot).

Excuse my ignorance, because I don't run this windowmanager, but what colors do other applications use for their menus, then?

From looking around the internet, it seems like this still ends up depending on GTK configuration, and you would need to configure this manually (viz. https://awesome.naquadah.org/wiki/Customizing_GTK_Apps ).

If gtk is providing us stupid values (e.g. black background + black text) then I'm not really sure what we can do about this...

Comment 11

[Vasilica Tamas, QA [:vtamas]]

This issue is reproducible also in Firefox 43.0a1 (2015-08-19) and Firefox 42.0a2 (2015-08-19) using the Default theme.

Here is the regression window:

(m-c)
Last good revision: 8e5c888d0d89
First bad revision: 1f77b78797d6
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8e5c888d0d89&tochange=1f77b78797d6

(m-i)
Last good revision: 1ee54e043b9b
First bad revision: 939320b957c5
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1ee54e043b9b&tochange=939320b957c5

Bug 1186003 caused this issue.

Comment 12

[:Gijs (he/him)]

I think this is essentially just wontfix/invalid, but maybe Karl can weigh in and say if there's something that either the theme or the GTK code needs to be doing differently?

Comment 13

[Karl Tomlinson (:karlt)]

Attachment 8649183 [details] seems to indicate a bug when Firefox is used with one theme, which is similar but not the same as bug 1187203.  But that is very different from the screenshots in comment 0.  It would be helpful to file a separate bug in Widget: Gtk re Attachment 8649183 [details] and identify the GTK theme that was in use.

Re the issue reported in comment 0, it is not necessarily a bug that popup menus look different to menubar menus (though I don't recall whether the widget code supports that distinction yet), but it is a bug that the submenus don't match their parent menus.  I don't know what is causing that bug, but I suspect this report is in the correct component.

Comment 14

[Simona Badau, Desktop Test Engineering]

Closing this as Resolved Worksforme as this is no longer an issue on Firefox Developer Edition 125.0b1 - per default the menus are now either dark (when the dark theme is selected), either white (when the white theme is enabled).