Closed Bug 1194700 Opened 9 years ago Closed 8 years ago

[e10s] Unnecessary zoom option in pdfjs

Categories

(Firefox :: PDF Viewer, defect, P3)

42 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 49
Tracking Status
e10s + ---

People

(Reporter: bmaris, Unassigned)

References

Details

(Whiteboard: [pdfjs-c-ux][pdfjs-f-fixed-upstream] https://github.com/mozilla/pdf.js/pull/7242)

Attachments

(1 file)

Affected builds:
- latest Aurora 42.0a2 (e10s only)
- latest Nighty 43.0a1 (e10s only)

Affected OS`s:
- Windows 7 64-bit
- Ubuntu 14.04 32-bit
- Mac OS X 10.10.4

STR:
1. Start Firefox
2. Open a sample pdf (eg: http://cp.literature.agilent.com/litweb/pdf/5989-8139EN.pdf)
3. Click Automatic Zoom.

Expected results: All the predefined zoom levels are correctly displayed.

Actual results: A random white space can be seen between Page Width and 50%. I noticed that if I select a random zoom level for example 110%, the white space will populate with this value but clicking it does nothing.

Notes:
- Not sure if this is a regression, need to investigate further.
- This is ONLY reproducible with e10s enabled.
Depends on: 1185394
Priority: -- → P3
Whiteboard: [pdfjs-c-ux]
(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #0)
> Notes:
> - Not sure if this is a regression, need to investigate further.

This is not a regression, the issues reproduces on old Nightly from 2014-08-18 where e10s was enabled by default in Nightly.
The only difference I see between Nightly and Release on Mac 10.9.5 is blank space on Nightly as opposed to a line separator on Release. I don't observe the blank space filling with any selected zoom level. It simply remains a blank space.

This is polish to put in the line separator.
tracking-e10s: --- → +
(In reply to [:tracy] Tracy Walker - QA Mentor from comment #2)
> The only difference I see between Nightly and Release on Mac 10.9.5 is blank
> space on Nightly as opposed to a line separator on Release. I don't observe
> the blank space filling with any selected zoom level. It simply remains a
> blank space.
> 
> This is polish to put in the line separator.

You need to select another zoom level not the ones already displayed. Using ctrl and '+/-' buttons to get a random value. The blank space will fill with that value, just tried again using latest Nightly 42.0a1 on Mac OS X 10.10.4.
Thanks Bogdan. I see the value filled in and checked now using +/-.  Looks to me like displaying the selected custom zoom level is a feature. :)  We need to find exactly what is intended behavior.  Still likely to be just polish to get the separator in there, instead of the custom value?
I would expect that the PDF Viewer should look the same with e10s enabled, as it currently does with e10s disabled; see the attached screen-shot for a comparison on Windows.

I assume that this bug will be fixed automatically once (the blocking) bug 1185394 is fixed.
Depends on: 910022
No longer depends on: 1185394
Depends on: 1270846
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [pdfjs-c-ux] → [pdfjs-c-ux][pdfjs-f-fixed-upstream] https://github.com/mozilla/pdf.js/pull/7242
Target Milestone: --- → Firefox 49
I was able to still reproduce this bug on 48.0b7 (20160711002726), using Windows 8.1 x64.
See Also: → 1315608
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: