Closed Bug 1194834 Opened 4 years ago Closed 4 years ago

Don't use static libs on Windows ASan builds

Categories

(Firefox Build System :: General, defect)

42 Branch
defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

ASan'ed code wants to link to the dynamic CRT, so it can't be mixed with the static CRT.
Attached patch patch (obsolete) — Splinter Review
This patch confuses "clang-cl builds" and "asan builds", so I guess it could use some cleanup if we want to be precise.
Assignee: nobody → dmajor
Attachment #8648200 - Attachment is obsolete: true
Attachment #8658778 - Flags: review?(mh+mozilla)
Attachment #8658778 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/6feccf342e7c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.