Closed Bug 1194834 Opened 8 years ago Closed 8 years ago

Don't use static libs on Windows ASan builds

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Version:
42 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox43 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: away, Assigned: away)

References

Details

Attachments

(1 file, 1 obsolete file)

asan_nostaticlibs
3.47 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
ASan'ed code wants to link to the dynamic CRT, so it can't be mixed with the static CRT.
Attached patch patch (obsolete) — — Splinter Review 
This patch confuses "clang-cl builds" and "asan builds", so I guess it could use some cleanup if we want to be precise.
Assignee: nobody → dmajor

        Attachment #8648200 -
        Attachment is obsolete: true

        Attachment #8658778 -
        Flags: review?(mh+mozilla)

        Attachment #8658778 -
        Flags: review?(mh+mozilla) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/6feccf342e7c
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox43:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.