about:privatebrowsing built-in page links to incorrect SUMO page

VERIFIED FIXED in Firefox 43

Status

()

Firefox
Private Browsing
P1
normal
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: javaun, Assigned: past)

Tracking

unspecified
Firefox 43
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox43 verified)

Details

(Whiteboard: [fxprivacy])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
There is a blue "See how this works" button that links to the old SUMO page (TP activated for normal mode via about:config)

The correct link should be the new page: 
https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/tracking-protection-pbm

Let's edit this and uplift for DevEdition build2. When the UI tour is ready, we'll link to that from the blue button
(Reporter)

Updated

3 years ago
Priority: -- → P1
Whiteboard: [fxprivacy]

Updated

3 years ago
Blocks: 1188565
(Assignee)

Updated

3 years ago
Assignee: nobody → past
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8650999 [details] [diff] [review]
Patch v1

Simple fix.
(Assignee)

Updated

3 years ago
Attachment #8650999 - Flags: review?(paolo.mozmail)

Updated

3 years ago
Iteration: --- → 43.1 - Aug 24
Flags: qe-verify?

Comment 2

3 years ago
Comment on attachment 8650999 [details] [diff] [review]
Patch v1

The link we need to change is the one for the button, while the Learn More link would still link to the current private browsing help page.

I think we'd simply need to change the privacy.trackingprotection.introURL preference instead of using the support base URL for the startTour button, because when the UI tour is ready we'd like to change the preference again to point to the external entry point for the tour rather than a SUMO page.
Attachment #8650999 - Flags: review?(paolo.mozmail)
(Assignee)

Comment 3

3 years ago
Created attachment 8651794 [details] [diff] [review]
Patch v2

D'oh! Yes, this makes more sense.
Attachment #8650999 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8651794 - Flags: review?(paolo.mozmail)

Comment 4

3 years ago
Comment on attachment 8651794 [details] [diff] [review]
Patch v2

Looks good to me, and we can remove the duplication in the preferences file.
Attachment #8651794 - Flags: review?(paolo.mozmail) → review+
(Assignee)

Comment 5

3 years ago
Thanks, I'll remove the first instance in the version that I will land.
https://hg.mozilla.org/mozilla-central/rev/cfc5cf4fdc51
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Hi Panos, can you set this bug to qe-verify- or qe-verify+
Flags: needinfo?(past)
(Assignee)

Updated

3 years ago
Flags: qe-verify?
Flags: qe-verify+
Flags: needinfo?(past)
Verified fixed FF 43.0a1 (2015-09-10) Win 7
Status: RESOLVED → VERIFIED
status-firefox43: fixed → verified
You need to log in before you can comment on or make changes to this bug.