Closed
Bug 1194864
Opened 9 years ago
Closed 9 years ago
about:privatebrowsing built-in page links to incorrect SUMO page
Categories
(Firefox :: Private Browsing, defect, P1)
Firefox
Private Browsing
Tracking
()
Tracking | Status | |
---|---|---|
firefox43 | --- | verified |
People
(Reporter: javaun, Assigned: past)
References
Details
(Whiteboard: [fxprivacy])
Attachments
(1 file, 1 obsolete file)
1.52 KB,
patch
|
Paolo
:
review+
|
Details | Diff | Splinter Review |
There is a blue "See how this works" button that links to the old SUMO page (TP activated for normal mode via about:config)
The correct link should be the new page:
https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/tracking-protection-pbm
Let's edit this and uplift for DevEdition build2. When the UI tour is ready, we'll link to that from the blue button
Reporter | ||
Updated•9 years ago
|
Priority: -- → P1
Whiteboard: [fxprivacy]
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → past
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Simple fix.
Assignee | ||
Updated•9 years ago
|
Attachment #8650999 -
Flags: review?(paolo.mozmail)
Updated•9 years ago
|
Iteration: --- → 43.1 - Aug 24
Flags: qe-verify?
Comment 2•9 years ago
|
||
Comment on attachment 8650999 [details] [diff] [review]
Patch v1
The link we need to change is the one for the button, while the Learn More link would still link to the current private browsing help page.
I think we'd simply need to change the privacy.trackingprotection.introURL preference instead of using the support base URL for the startTour button, because when the UI tour is ready we'd like to change the preference again to point to the external entry point for the tour rather than a SUMO page.
Attachment #8650999 -
Flags: review?(paolo.mozmail)
Assignee | ||
Comment 3•9 years ago
|
||
D'oh! Yes, this makes more sense.
Attachment #8650999 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Attachment #8651794 -
Flags: review?(paolo.mozmail)
Comment 4•9 years ago
|
||
Comment on attachment 8651794 [details] [diff] [review]
Patch v2
Looks good to me, and we can remove the duplication in the preferences file.
Attachment #8651794 -
Flags: review?(paolo.mozmail) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Thanks, I'll remove the first instance in the version that I will land.
Comment 7•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Comment 8•9 years ago
|
||
Hi Panos, can you set this bug to qe-verify- or qe-verify+
Flags: needinfo?(past)
Assignee | ||
Updated•9 years ago
|
Flags: qe-verify?
Flags: qe-verify+
Flags: needinfo?(past)
You need to log in
before you can comment on or make changes to this bug.
Description
•