Closed Bug 1194874 Opened 4 years ago Closed 3 years ago

Maybe switch "run by" text to "owned by" for EV certificates in the Control Center

Categories

(Firefox :: Security, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 49
Tracking Status
firefox43 --- affected
firefox49 --- fixed

People

(Reporter: bgrins, Assigned: cmassim, Mentored)

References

Details

(Whiteboard: [fxprivacy] [good first bug])

Attachments

(1 file, 1 obsolete file)

In Bug 1191044 we removed the 'Firefox verified that' portion of the text about EV certificates.  There was a suggestion that 'run by' should switch to 'owned by' also.  Moving that discussion into this bug.

(April King from comment #10)
> That text works for me, although I would note that it's more accurate to say
> "owned by" than it is to say "run by", since most sites are not run by the
> person who owns them.
"operated by" might work too.
Note that if you click "More Information" it says "Owner". However, I think we should get rid of this sliding dialog altogether. It's not worth the complexity given that "More Information" exists. I filed bug 1194938 on that.
(In reply to Anne (:annevk) from comment #2)
> Note that if you click "More Information" it says "Owner". However, I think
> we should get rid of this sliding dialog altogether. It's not worth the
> complexity given that "More Information" exists. I filed bug 1194938 on that.

Note that the sliding dialog also contains mixed content blocking information and control to disable / enable MCB
Indeed, you're correct, I think my main argument that "run by" and "verified by" are not helping the user still stand though.

I also do still think that in the majority of cases that arrow is a distraction and clicking it doesn't result in a user benefit. So perhaps we should reconsider some aspects of it.
Priority: -- → P2
Blocks: 1188565
Priority: P2 → P3
Blocks: 1216897
No longer blocks: 1188565
Based on:

(In reply to agrigas from bug 1194938 comment #17)
> We're going to go forward with what we have and will re-address adding in
> additional security info down the road.

is this also wontfix, or is there still something to be done here? If so, can we make this a simple mentored bug to switch to the alternative labels?
Component: General → Security
Flags: needinfo?(agrigas)
Will update to owned by
Flags: needinfo?(agrigas)
Johann, do you want to pick this string change up?
Flags: needinfo?(jhofmann)
Hey Tanvi, thanks for asking! I could do it, but if it's really just a string change I would rather let someone new from the community take it :)
Flags: needinfo?(jhofmann)
Whiteboard: [fxprivacy] → [fxprivacy] [good first bug]
Mentor: jhofmann
Assignee: nobody → cmassim
Comment on attachment 8756957 [details] [diff] [review]
Change 'run by' to 'owned by' in the Control Center

Hey there, thanks for contributing! This is a really tiny change that probably doesn't require tests. So we should be good to go. However, we need someone to review it.

Gijs, do you have a minute?
Attachment #8756957 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8756957 [details] [diff] [review]
Change 'run by' to 'owned by' in the Control Center

Review of attachment 8756957 [details] [diff] [review]:
-----------------------------------------------------------------

This is close, but we need to rev the string ID (so make it identity.connectionVerified2) both here and in the place the string is used (here: https://dxr.mozilla.org/mozilla-central/rev/8d0aadfe7da782d415363880008b4ca027686137/browser/locales/en-US/chrome/browser/browser.dtd#685 ) , so that localizers to other languages will also update their strings.
Attachment #8756957 - Flags: review?(gijskruitbosch+bugs) → feedback+
Attachment #8756957 - Attachment is obsolete: true
Comment on attachment 8757021 [details] [diff] [review]
Updates string ID to reflect string change

Review of attachment 8757021 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!
Attachment #8757021 - Flags: review+
Setting checkin-needed so the sheriffs will land this for us. :-)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f2125a888d23
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.