Closed
Bug 1194886
Opened 10 years ago
Closed 10 years ago
Make test_bug523771.html work with e10s
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla43
People
(Reporter: mrbkap, Assigned: mrbkap)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
4.43 KB,
patch
|
jld
:
review+
|
Details | Diff | Splinter Review |
This test attempts to create files in the profile directory, which is a no-no in e10s. Fortunately, we can easily use DOM files backed by DOM strings to fix the test.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8648286 -
Flags: review?(jld)
Comment 2•10 years ago
|
||
Comment on attachment 8648286 [details] [diff] [review]
Patch v1
Review of attachment 8648286 [details] [diff] [review]:
-----------------------------------------------------------------
r+ with a couple comments.
Nit: maybe the commit message could be a little more specific?
::: dom/html/test/test_bug523771.html
@@ +32,5 @@
> SimpleTest.waitForExplicitFinish();
>
> function setFileInputs () {
> + var f = createFileWithData(input1File.name, input1File.body, input1File.type);
> + SpecialPowers.wrap(singleFileInput).mozSetFileArray([f], 1);
mozSetFileArray just takes a sequence<File>; it doesn't need the length passed separately. (And I think mozSetFileNameArray doesn't need it either, these days; it's in the XPIDL but not the WebIDL.)
@@ +42,2 @@
> }
> + SpecialPowers.wrap(multiFileInput).mozSetFileArray(input2FileNames, input2FileNames.length);
And here.
Attachment #8648286 -
Flags: review?(jld) → review+
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox43:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•