1194886 - Make test_bug523771.html work with e10s

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

This test attempts to create files in the profile directory, which is a no-no in e10s. Fortunately, we can easily use DOM files backed by DOM strings to fix the test.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch v1

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8648286 [details] [diff] [review]
Patch v1

Review of attachment 8648286 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with a couple comments.

Nit: maybe the commit message could be a little more specific?

::: dom/html/test/test_bug523771.html
@@ +32,5 @@
>  SimpleTest.waitForExplicitFinish();
>  
>  function setFileInputs () {
> +  var f = createFileWithData(input1File.name, input1File.body, input1File.type);
> +  SpecialPowers.wrap(singleFileInput).mozSetFileArray([f], 1);

mozSetFileArray just takes a sequence<File>; it doesn't need the length passed separately.  (And I think mozSetFileNameArray doesn't need it either, these days; it's in the XPIDL but not the WebIDL.)

@@ +42,2 @@
>    }
> +  SpecialPowers.wrap(multiFileInput).mozSetFileArray(input2FileNames, input2FileNames.length);

And here.

Comment 3

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/4dc348b4f780

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4dc348b4f780