1194951 - Suppress warnings in third-party code: pocketsphinx and sphinxbase

Status: RESOLVED FIXED

(Core :: Web Speech, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: pocketsphinx-suppress-warnings.patch

media/pocketsphinx/src/dict.c:312:18: warning: passing 'const char *' to parameter of type 'void *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]

media/pocketsphinx/src/dict.c:571:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]

media/sphinxbase/src/libsphinxbase/util/blas_lite.c:101:2: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
media/sphinxbase/src/libsphinxbase/util/blas_lite.c:102:3: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
media/sphinxbase/src/libsphinxbase/util/blas_lite.c:105:2: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
media/sphinxbase/src/libsphinxbase/util/blas_lite.c:106:3: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
media/sphinxbase/src/libsphinxbase/util/blas_lite.c:425:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
media/sphinxbase/src/libsphinxbase/util/blas_lite.c:726:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
media/sphinxbase/src/libsphinxbase/util/blas_lite.c:1138:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
media/sphinxbase/src/libsphinxbase/util/blas_lite.c:1450:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses]

Comment 1

[kdavis]

Comment on attachment 8648351 [details] [diff] [review]
pocketsphinx-suppress-warnings.patch

Review of attachment 8648351 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/pocketsphinx/moz.build
@@ +47,5 @@
>  # Suppress warnings in third-party code.
>  if CONFIG['GNU_CC']:
> +    CFLAGS += [
> +        '-Wno-declaration-after-statement',
> +        '-Wno-parentheses',

Is this needed for the pocketsphinx code? From the warnings you provided
it looks as if it's only required for the sphinxbase code.

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to kdavis from comment #1)
> > +        '-Wno-parentheses',
> 
> Is this needed for the pocketsphinx code? From the warnings you provided
> it looks as if it's only required for the sphinxbase code.

Good catch! :) I just confirmed that -Wno-parentheses is only needed for the sphinxbase code. I'll remove that -Wno-parentheses when landing this patch.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc0b3938e464

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dc0b3938e464