Closed
Bug 1194954
Opened 9 years ago
Closed 9 years ago
Fix -Wunreachable-code warnings in gfx/layers and gfx/thebes
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.40 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
Fix the following -Wunreachable-code warnings. Also rearrange two switch statements to remove their default cases so gcc/clang will report -Wswitch warnings about unhandled enum values if new Layer type or eGfxLog enum values are added in the future.
gfx/layers/LayerTreeInvalidation.cpp:430:41 [-Wunreachable-code-return] 'return' will never be executed
gfx/thebes/gfxPlatform.cpp:2168:9 [-Wunreachable-code-break] 'break' will never be executed
gfx/thebes/gfxPlatform.cpp:2171:9 [-Wunreachable-code-break] 'break' will never be executed
gfx/thebes/gfxPlatform.cpp:2174:9 [-Wunreachable-code-break] 'break' will never be executed
gfx/thebes/gfxPlatform.cpp:2177:9 [-Wunreachable-code-break] 'break' will never be executed
gfx/thebes/gfxPlatform.cpp:2180:9 [-Wunreachable-code-break] 'break' will never be executed
gfx/thebes/gfxPlatform.cpp:2183:9 [-Wunreachable-code-break] 'break' will never be executed
Attachment #8648353 -
Flags: review?(bgirard)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8648353 [details] [diff] [review]
Wunreachable-code_gfx.patch
Review of attachment 8648353 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you!
Attachment #8648353 -
Flags: review?(bgirard) → review+
|
||
Comment 3•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
|
Assignee | |
Updated•9 years ago
|
Blocks: Wunreachable-code
You need to log in
before you can comment on or make changes to this bug.
Description
•