1194955 - Fix -Wunreachable-code warnings in dom/ipc and dom/plugins

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: Wunreachable-code_dom.patch

dom/ipc/ProcessHangMonitor.cpp:601:5 [-Wunreachable-code-break] 'break' will never be executed
dom/plugins/base/nsNPAPIPlugin.cpp:2647:5 [-Wunreachable-code-break] 'break' will never be executed
dom/plugins/base/nsPluginHost.cpp:3324:10 [-Wunreachable-code-return] 'return' will never be executed
dom/plugins/ipc/PluginInstanceChild.cpp:3445:24 [-Wunreachable-code] code will never be executed

Comment 1

[Jim Mathies [:jimm]]

Comment on attachment 8648354 [details] [diff] [review]
Wunreachable-code_dom.patch

Review of attachment 8648354 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/base/nsPluginHost.cpp
@@ -3563,5 @@
>        rv = NS_ERROR_NULL_POINTER;
>        return rv;
>      }
>    }
> -  return rv;

How is this method compiling without a return result? oh, hmm, a strange while loop with no breaks.. weird. A push to try for builds on all platforms might be good.

Comment 2

[Chris Peterson [:cpeterson]]

Thanks! Here's a green try build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d447eec1d31

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f8d5468dbcd

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1f8d5468dbcd