1194985 - avoid shift overflows in devtools server tests

Status: RESOLVED DUPLICATE of bug 1198980

(DevTools :: General, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: avoid shift overflows in devtools gtests

clang complains about shifting quantities beyond the width of their
type, since that is undefined behavior.  Let's fix the problematic
occurrences by adding some casts prior to shifting.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8648376 [details] [diff] [review]
avoid shift overflows in devtools gtests

Review of attachment 8648376 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4cd6c8c9ced

Comment 4

[Nathan Froyd [:froydnj]]

Backed out because the test was apparently depending on truncation of the values, or something?

https://hg.mozilla.org/integration/mozilla-inbound/rev/a30421f03bc5