Closed
Bug 1194985
Opened 9 years ago
Closed 9 years ago
avoid shift overflows in devtools server tests
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1198980
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.29 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
clang complains about shifting quantities beyond the width of their
type, since that is undefined behavior. Let's fix the problematic
occurrences by adding some casts prior to shifting.
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8648376 -
Flags: review?(nfitzgerald)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8648376 [details] [diff] [review]
avoid shift overflows in devtools gtests
Review of attachment 8648376 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8648376 -
Flags: review?(nfitzgerald) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Backed out because the test was apparently depending on truncation of the values, or something?
https://hg.mozilla.org/integration/mozilla-inbound/rev/a30421f03bc5
|
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•