1195018 - Implement support for `background_color` member in manifest processor

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Marco Castelluccio [:marco]]

Attachment: manifest_background_color

Comment 2

[Marcos Caceres [:marcosc]]

Comment on attachment 8708986 [details] [diff] [review]
manifest_background_color

Review of attachment 8708986 [details] [diff] [review]:
-----------------------------------------------------------------

Don't we also want basically the same tests that we have for theme_color to be used for background color? I'll leave it to your discretion if it's worth testing, as *_color things all basically use the same code path.

Comment 3

[Marco Castelluccio [:marco]]

(In reply to Marcos Caceres [:marcosc] from comment #2)
> Don't we also want basically the same tests that we have for theme_color to
> be used for background color? I'll leave it to your discretion if it's worth
> testing, as *_color things all basically use the same code path.

There were no tests for theme_color, so I've opened bug 1240735 to track adding them.
I'll add background_color tests in that bug as well.

Comment 4

[Marcos Caceres [:marcosc]]

how odd... I distinctly remember writing some :/ I guess they got lost along the way :(

Comment 5

[Marcos Caceres [:marcosc]]

Attachment: test_ManifestProcessor_icons_background_color.html

Ah, I remember now... there was a proposal for an icon_background_color member that hasn't made into the spec. I wrote color tests from those. feel free to adapt the attached if you would like :) Maybe save you a bit of time.

Comment 6

[Marco Castelluccio [:marco]]

(In reply to Marcos Caceres [:marcosc] from comment #5)
> Ah, I remember now... there was a proposal for an icon_background_color
> member that hasn't made into the spec. I wrote color tests from those. feel
> free to adapt the attached if you would like :) Maybe save you a bit of time.

Thanks! I've used the valid and invalid examples from test_ImageObjectProcessor_background_color.html (which are the same as the ones in the file you've just attached) to write the tests (patch attached to bug 1240735).

Comment 7

[Marco Castelluccio [:marco]]

Attachment: manifest_background_color

Carrying r+.

Comment 8

[Marco Castelluccio [:marco]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/031e4d03ebb826cad1b224fc4fc26dc706dbe4ee
Bug 1195018 - Support 'background_color' member in the manifest processor. r=marcosc

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/031e4d03ebb8