Closed Bug 1195051 Opened 4 years ago Closed 4 years ago

Creating an AudioContext shows the tab sound indicator even without anything playing

Categories

(Core :: Web Audio, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(3 files)

Bug 1041594 made us unmute the input as soon as the audio channel agent is created, which happens when an AudioContext gets created.  As a result, the tab audio indicator shows up even without anything playing.

A better way to fix that race condition is to create the audio channel agent in InputMuted if it doesn't exist yet.
Attachment #8648436 - Flags: review?(padenot)
Attachment #8648437 - Flags: review?(padenot)
Attachment #8648438 - Flags: review?(padenot)
Duplicate of this bug: 1195108
Attachment #8648436 - Flags: review?(padenot) → review+
Attachment #8648437 - Flags: review?(padenot) → review+
Attachment #8648438 - Flags: review?(padenot) → review+
Comment on attachment 8648436 [details] [diff] [review]
Part 1: Do not unmute the destination node as soon as the AudioContext is constructed; r=padenot

(Requesting approval for the whole patch series)

Approval Request Comment
[Feature/regressing bug #]: Tab audio indicators
[User impact if declined]: On websites such as <http://icelandairwaves.is/> where an AudioContext is created but no audio is played back, we currently show the tab audio indicator icon.  These patches fix that bug.
[Describe test coverage new/current, TreeHerder]: Has tests.
[Risks and why]: Low risk, and has a test.
[String/UUID change made/needed]: None.
Attachment #8648436 - Flags: approval-mozilla-aurora?
Comment on attachment 8648436 [details] [diff] [review]
Part 1: Do not unmute the destination node as soon as the AudioContext is constructed; r=padenot

This needs to wait while we figure out bug 1195805.
Attachment #8648436 - Flags: approval-mozilla-aurora?
Depends on: 1195805
Comment on attachment 8648436 [details] [diff] [review]
Part 1: Do not unmute the destination node as soon as the AudioContext is constructed; r=padenot

See comment 6.  Bug 1195805 ended up being a gaia bug.
Attachment #8648436 - Flags: approval-mozilla-aurora?
Comment on attachment 8648436 [details] [diff] [review]
Part 1: Do not unmute the destination node as soon as the AudioContext is constructed; r=padenot

Polish of the feature and avoid confusion, taking it.
Attachment #8648436 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.