1195051 - Creating an AudioContext shows the tab sound indicator even without anything playing

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[(no longer active)]

Bug 1041594 made us unmute the input as soon as the audio channel agent is created, which happens when an AudioContext gets created.  As a result, the tab audio indicator shows up even without anything playing.

A better way to fix that race condition is to create the audio channel agent in InputMuted if it doesn't exist yet.

Comment 1

[(no longer active)]

Attachment: Part 1: Do not unmute the destination node as soon as the AudioContext is constructed; r=padenot

Comment 2

[(no longer active)]

Attachment: Part 2: Mute the destination node when the AudioContext is suspended, and unmute when resumed; r=padenot

Comment 3

[(no longer active)]

Attachment: Part 3: Test changes; r=padenot

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4f1b7f9d6f23
https://hg.mozilla.org/integration/mozilla-inbound/rev/4abc258b07a7
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a66bd178c4c

Comment 6

[(no longer active)]

Comment on attachment 8648436 [details] [diff] [review]
Part 1: Do not unmute the destination node as soon as the AudioContext is constructed; r=padenot

(Requesting approval for the whole patch series)

Approval Request Comment
[Feature/regressing bug #]: Tab audio indicators
[User impact if declined]: On websites such as <http://icelandairwaves.is/> where an AudioContext is created but no audio is played back, we currently show the tab audio indicator icon.  These patches fix that bug.
[Describe test coverage new/current, TreeHerder]: Has tests.
[Risks and why]: Low risk, and has a test.
[String/UUID change made/needed]: None.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/36895151defd

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4f1b7f9d6f23
https://hg.mozilla.org/mozilla-central/rev/4abc258b07a7
https://hg.mozilla.org/mozilla-central/rev/5a66bd178c4c
https://hg.mozilla.org/mozilla-central/rev/36895151defd

Comment 9

[(no longer active)]

Comment on attachment 8648436 [details] [diff] [review]
Part 1: Do not unmute the destination node as soon as the AudioContext is constructed; r=padenot

This needs to wait while we figure out bug 1195805.

Comment 10

[(no longer active)]

Comment on attachment 8648436 [details] [diff] [review]
Part 1: Do not unmute the destination node as soon as the AudioContext is constructed; r=padenot

See comment 6.  Bug 1195805 ended up being a gaia bug.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8648436 [details] [diff] [review]
Part 1: Do not unmute the destination node as soon as the AudioContext is constructed; r=padenot

Polish of the feature and avoid confusion, taking it.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6027386fe7c0
https://hg.mozilla.org/releases/mozilla-aurora/rev/aad62dcde4fa
https://hg.mozilla.org/releases/mozilla-aurora/rev/4c03f5377b64
https://hg.mozilla.org/releases/mozilla-aurora/rev/67b001dbd4ca