1195094 - H264Converter not properly extracting SPS for decoder requiring AnnexB

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

The H264Converter monitors the SPS NAL in incoming H264 compressed samples.

The tool to do so only works with AVCC samples.

However, the first thing the H264Converter does is convert samples to AnnexB. So the code in place just doesnt work as it is.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: P2. Ensure TrackInfo object passed to constructor is never modified

Ensure original TrackInfo isn't modified. Amend the PDM documentation so that the reference to the TrackInfo object is to be copied

Comment 2

[Jean-Yves Avenard [:jya]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5733ed90de6d

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: P1. Properly detects SPS changes for decoders requiring Annex B

detect SPS change for decoder requiring AnnexB (Gonk/WMF)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb0870b54aef
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4401440ad83

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bb0870b54aef
https://hg.mozilla.org/mozilla-central/rev/b4401440ad83