Closed Bug 1195094 Opened 4 years ago Closed 4 years ago

H264Converter not properly extracting SPS for decoder requiring AnnexB

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- affected
firefox44 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(2 files)

The H264Converter monitors the SPS NAL in incoming H264 compressed samples.

The tool to do so only works with AVCC samples.

However, the first thing the H264Converter does is convert samples to AnnexB. So the code in place just doesnt work as it is.
Priority: -- → P5
Blocks: 1217226
Priority: P5 → P2
Assignee: nobody → jyavenard
Ensure original TrackInfo isn't modified. Amend the PDM documentation so that the reference to the TrackInfo object is to be copied
Attachment #8677856 - Flags: review?(cpearce)
Attachment #8677856 - Flags: review?(cpearce) → review+
detect SPS change for decoder requiring AnnexB (Gonk/WMF)
Attachment #8677871 - Flags: review?(cpearce)
Attachment #8677871 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/bb0870b54aef
https://hg.mozilla.org/mozilla-central/rev/b4401440ad83
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Depends on: 1237809
You need to log in before you can comment on or make changes to this bug.