1195182 - Broken AUR package link for uuid in bootstrap.py script for Arch Linux

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[u546977]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150811061821

Steps to reproduce:

Wanting to build Firefox on my newly installed Arch Linux system, I ran the bootstrap.py script from https://developer.mozilla.org/en-US/docs/Simple_Firefox_build/Linux_and_MacOS_build_preparation to install all the required dependencies. After selecting Firefox for desktop as my choice, the script proceeded to install the dependencies.


Actual results:

The script exited because the AUR link for the required uuid package (https://github.com/mozilla/gecko-dev/blob/master/python/mozboot/mozboot/archlinux.py#L63) is broken since the AUR has been recently updated.

Here is the error log for the curious:

WARNING! This script requires to install packages from the AUR This is potentially unsecure so I recommend that you carefully read each package description and check the sources.These packages will be built in /tmp/tmpWCVViT.
Do you want to continue? (yes/no) [no]yes
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   168  100   168    0     0    360      0 --:--:-- --:--:-- --:--:--   360

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
Traceback (most recent call last):
  File "bootstrap.py", line 163, in <module>
    sys.exit(main(sys.argv))
  File "bootstrap.py", line 154, in main
    dasboot.bootstrap()
  File "/tmp/tmpDUOtPW/mozboot/bootstrap.py", line 131, in bootstrap
    parser.add_option('--repo-type', dest='repo_type',
  File "/tmp/tmpDUOtPW/mozboot/archlinux.py", line 72, in install_system_packages
  File "/tmp/tmpDUOtPW/mozboot/archlinux.py", line 143, in aur_install
  File "/tmp/tmpDUOtPW/mozboot/archlinux.py", line 118, in unpack
  File "/tmp/tmpDUOtPW/mozboot/archlinux.py", line 102, in run
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['tar', '-x', '-z', '-f', '/tmp/tmpWCVViT/uuid.tar.gz', '-C', '/tmp/tmpWCVViT']' returned non-zero exit status 2

Here, subprocess is raising CalledProcessError because the 'tar' command was unsuccessful since the file doesn't exist due to the broken link. Simply updating the link should fix the problem.



Expected results:

The script should have proceeded to install the required dependencies to build Firefox.

Comment 1

[Niels De Graef]

Attachment: The patch to fix the broken link to uuid

This should fix it (worked for me).

Comment 2

[aleth [:aleth]]

Comment on attachment 8648969 [details] [diff] [review]
The patch to fix the broken link to uuid

Review of attachment 8648969 [details] [diff] [review]:
-----------------------------------------------------------------

When you attach a patch, you should request review from a peer of the code you are fixing. Otherwise it might not be seen ;)

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8648969 [details] [diff] [review]
The patch to fix the broken link to uuid

Review of attachment 8648969 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

(We really need continuous integration verifying our bootstrap scripts work.)

I'll land this for you. Thank you for the fix!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6e090c6621e

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f6e090c6621e