1195263 - ARM Instruction::extractCond might leave the out-param uninitialized.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: ARM: Instruction::extractCond asserts that the instruction has a condition flag.

This modification pass the test suite with a debug build.

Comment 2

[Sean Stangl [:sstangl]]

Urgh, thank you.

All of those hardcoded constants in extractCond() should probably have names, possibly defined in a v8-style "constants" file.

Bug 1157934 is going to import the v8 constants file, maybe we could use those?

Comment 3

[Nicolas B. Pierron [:nbp]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e141cf07341e

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc0a4fd0e22d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cc0a4fd0e22d