Closed Bug 1195279 Opened 10 years ago Closed 10 years ago

Fix typo in allDownloadsViewOverlay.js following landing of bug 1127867

Categories

(Firefox :: File Handling, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

When the patch to bug 1127867 landed there was a typo as per https://bugzilla.mozilla.org/show_bug.cgi?id=1127867#c5 > Comment on attachment 8557121 [details] [diff] [review] > The patch > > >+++ b/browser/components/downloads/content/allDownloadsViewOverlay.js > > >+ // These properties may be updated if the user interface is refreshed. > >+ this.exists = false; > Should this be: > this.target.exists = false; > instead? > >+ this.target.size = undefined; > > }
Attached patch Add target fix (obsolete) — Splinter Review
Attachment #8648702 - Flags: review?(paolo.mozmail)
Comment on attachment 8648702 [details] [diff] [review] Add target fix Thanks a lot!
Attachment #8648702 - Flags: review?(paolo.mozmail) → review+
Keywords: checkin-needed
Note for sheriffs: I'm quite confident this fix doesn't require a full try run.
Attached patch Add target fixSplinter Review
Carrying forward r+
Attachment #8648702 - Attachment is obsolete: true
Attachment #8648709 - Flags: review+
Version: unspecified → Trunk
Please make sure the patch has the correct author information in the future before requesting checkin-needed, so we don't have to manually add that information when dealing with checkin-needed patches.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: