11953 - [WebShell/Necko] OnEndDocumentLoad not firing

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Stephen P. Morse]

The OnEndDocumentLoad handler in extensions/wallet/src/nsWalletService.cpp is
never being entered.  This breaks single signon's prefill which is dependent on
this handler.

Comment 1

[Eric Pollmann]

I could be wrong, but this sounds like a webshell issue.  Nisheeth, are you
still in charge of that area or has Scott taken it over?

Comment 2

[Nisheeth Ranjan]

Yes, Scott is the official webshell owner post-M9.  Steve, I'm really busy
preparing for an XML demo on Friday and won't be able to take a look at this
bug for this week.  Scott, do you have cycles that you could spend on this bug?
If so, please re-assign this to yourself.  Also, ccing Rick Potts who said that
he would be working on streamlining document load notifications.  Rick, this
looks like a regression due to Necko.

Comment 3

[Peter Trudelle]

reassigning to scc for triage, cc jevering.  Should we hold M9 for this?

Comment 4

[Suresh Duddi (gone)]

Warren sez rick potts is the right person to look at this.

Comment 5

[Dan M]

The EndDocumentLoad notification is fired, but never makes it all the way to the topmost (service) docloader
for dissemination to its observers because some (Necko) loadgroup is still busy at the time.  In fact, it never goes
unbusy.  Loadgroups look to be Warren's, so I'm wondering if he wants this bug himself.  Nevertheless
leaving assignee alone for now, though I'm adding him to the spamlist.

Comment 6

[rpotts (gone)]

This "should" be fixed on the M9 branch...  There is no test case, so I can't
verify this :-(  According to the PR_LOG messages OnEndDocumentLoad is firing
all the way up to the global document loader service...

I'll keep it open until I merge these changes back onto the tip.
-- rick

Comment 7

[Stephen P. Morse]

Want a test case?  Just set a breakpoint on the OnEndDocumentLoad handler in
extensions/wallet/src/nsWalletSerice.cpp.  You should get to that breakpoint
each time you load in a page.  But currently you are never getting to it.

Comment 8

[Paul MacQuiddy]

For the record, I can confirm that this is fixed on the M9 Branch.

Comment 9

[rpotts (gone)]

I've landed the M9 branch...

Comment 10

[Paul MacQuiddy]

I verified this on today's tip builds.