Last Comment Bug 1195362 - Quicksearch error pages ("foo is not a field" and friends) should still fill in search into quicksearch box
: Quicksearch error pages ("foo is not a field" and friends) should still fill ...
Status: RESOLVED FIXED
:
Product: bugzilla.mozilla.org
Classification: Other
Component: Search (show other bugs)
: Production
: Unspecified Unspecified
-- normal (vote)
: ---
Assigned To: David Lawrence [:dkl]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-08-17 08:49 PDT by :Gijs
Modified: 2015-08-19 10:30 PDT (History)
1 user (show)
See Also:
Due Date:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
1195362_1.patch (2.92 KB, patch)
2015-08-18 06:18 PDT, David Lawrence [:dkl]
glob: review+
Details | Diff | Splinter Review

Description User image :Gijs 2015-08-17 08:49:38 PDT
STR:

I have a bugzilla quicksearch bookmark keyword, so I can type things like:

bug prod:Firefox comp:Pref delta_ts>1d

to quickly search bugzilla.

Now if I make a typo, and type, for instance,


bug prodd:Firefox comp:Pref delta_ts>1d

I get an error page telling me:


> There is a problem with your search:
> prodd is not a valid field name.
> The legal field names are listed here.


That is all very well, but now the search I did does not appear in the quicksearch field at the top of bugzilla, and so I can't easily edit my search. I have to go into the URL bar and scan my (now URI-escaped) URI, which is a lot more hassle.

It would be nice if the failed query was still put in the quicksearch input box on the result page, even if it caused an error like this.
Comment 1 User image David Lawrence [:dkl] 2015-08-18 06:18:05 PDT
Created attachment 8649254 [details] [diff] [review]
1195362_1.patch
Comment 2 User image Byron Jones ‹:glob› 2015-08-18 23:16:22 PDT
Comment on attachment 8649254 [details] [diff] [review]
1195362_1.patch

Review of attachment 8649254 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

this looks good, except you missed the quicksearch_invalid_query error on line 172.
fix on commit please.
Comment 3 User image David Lawrence [:dkl] 2015-08-19 10:30:51 PDT
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   4d855c2..df1f6c9  master -> master

Note You need to log in before you can comment on or make changes to this bug.