1195577 - Add JS_SetUntrustedPrincipals to mirror JS_SetTrustedPrincipals

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

See bug 1194424 comment 12

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Add JS_SetUntrustedPrincipals

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8649024 [details] [diff] [review]
Add JS_SetUntrustedPrincipals

Review of attachment 8649024 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/public/Principals.h
@@ +95,5 @@
> + * Just like the trusted principals, this principals is not held by the runtime,
> + * so the embedder must ensure that `prin` outlives the runtime.
> + */
> +extern JS_PUBLIC_API(void)
> +JS_SetUntrustedPrincipals(JSRuntime* rt, JSPrincipals* prin);

Bleh. Who started this 'prin' abbreviation thing? It's weird. (And not your problem.)

::: js/src/vm/Runtime.h
@@ +1243,5 @@
>      }
>  
>    private:
>      const JSPrincipals* trustedPrincipals_;
> +    JSPrincipals* untrustedPrincipals_;

What's the state of the constness? It seems weird to have them be different here. I'm still voting for const with mutable refcount.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Steve Fink [:sfink, :s:] from comment #2)
> ::: js/src/vm/Runtime.h
> @@ +1243,5 @@
> >      }
> >  
> >    private:
> >      const JSPrincipals* trustedPrincipals_;
> > +    JSPrincipals* untrustedPrincipals_;
> 
> What's the state of the constness? It seems weird to have them be different
> here. I'm still voting for const with mutable refcount.

The trusted principals become non-const in part 3 of bug 1194424, but I rebased that series on top of this one.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

After talking to bholley, we decided to go a different route in bug 1194424 rather than using trusted/untrusted principals.