Error message is not clear when looking for inbounds using changesets that are in the same push

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: parkouss, Assigned: parkouss)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
See bug 1195524. When a user give valid changesets that are in the same push, mozregression only say "No inbound data found".

This is confusing and we could be a bit more explicit.
(Assignee)

Comment 1

3 years ago
Created attachment 8649157 [details] [review]
Bug 1195622 - Inbound error messages fixes

So I fixed this, and a couple of other minor things along the way (see the commits in the PR).

So now, when a user gives two changesets that are in the same push:

mozregression --good-rev 3f135a8ead22 --bad-rev 8cba870a352c
>  0:09.31 LOG: MainThread Build Finder INFO Found 1 pushlog entries using `https://hg.mozilla.org/integration/mozilla-inbound/json-pushes?fromchange=3f135a8ead22&tochange=8cba870a352c`
>  0:16.90 LOG: MainThread Bisector INFO Oh noes, no (more) inbound revisions :(
>  0:16.90 LOG: MainThread Bisector INFO Last good revision: c4ab17503c0985da0e03f13a7331f216c3661ecc
>  0:16.90 LOG: MainThread Bisector INFO First bad revision: c4ab17503c0985da0e03f13a7331f216c3661ecc
>  0:16.90 LOG: MainThread Bisector INFO Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=c4ab17503c0985da0e03f13a7331f216c3661ecc
> 
>  0:16.90 LOG: MainThread Bisector WARNING It seems that you used two changesets that are in in the same push. Check the pushlog url.

So no more "No inbound data found". The valid push log url is printed along with a warning.


Also, when giving bad changeset(s):

mozregression --good-rev 3f135a8ead22111 --bad-rev 8cba870a352c111
>  0:01.80 LOG: MainThread Bisector INFO Getting inbound builds between 3f135a8ead22111 and 8cba870a352c111
>  0:03.53 LOG: MainThread ERROR The url 'https://hg.mozilla.org/integration/mozilla-inbound/json-pushes?changeset=3f135a8ead22111' returned a 404 error. Please check the validity of the given changesets ('3f135a8ead22111', '8cba870a352c111').
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Attachment #8649157 - Flags: review?(wlachance)
Comment on attachment 8649157 [details] [review]
Bug 1195622 - Inbound error messages fixes

This looks great, thanks!
Attachment #8649157 - Flags: review?(wlachance) → review+
(Assignee)

Comment 3

3 years ago
Thanks Will!

Merged in https://github.com/mozilla/mozregression/commit/cf509873ee4f028c810e06a7ac6269b9bd153cef.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.