Closed Bug 1195625 Opened 7 years ago Closed 7 years ago

Use correct TaskQueue in SharedDecoderManager and H264Converter promise.

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: ayang, Assigned: ayang)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch use_correct_taskqueue (obsolete) — Splinter Review
Attachment #8649122 - Flags: review?(jyavenard)
Comment on attachment 8649122 [details] [diff] [review]
use_correct_taskqueue

Review of attachment 8649122 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/platforms/SharedDecoderManager.cpp
@@ +186,5 @@
>  
>      nsRefPtr<SharedDecoderManager> self = this;
>      nsRefPtr<MediaDataDecoder::InitPromise> p = mDecoderInitPromise.Ensure(__func__);
>  
> +    // The mTaskQueue is flushable which can't be used in MozPromise.

same as H264Converter comment

::: dom/media/platforms/wrappers/H264Converter.cpp
@@ +167,5 @@
>      mMediaRawSamples.AppendElement(aSample);
>  
>      nsRefPtr<H264Converter> self = this;
>  
> +    // The mVideoTaskQueue is flushable which can't be used in MozPromise.

even if it wasn't flushable ; we wouldn't want to use it as it would cause thread-safety issues with the wrapped MediaDataDecoder which expects to control all that is going with its own task queue.

So that comment needs to be entirely removed because it's incorrect.
Attachment #8649122 - Flags: review?(jyavenard) → review+
Thanks for quick review!
Attachment #8649122 - Attachment is obsolete: true
Attachment #8649125 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/88df6aa8bf02
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Depends on: 1199809
You need to log in before you can comment on or make changes to this bug.