1195625 - Use correct TaskQueue in SharedDecoderManager and H264Converter promise.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Comment 1

[Alfredo Yang (:alfredo)]

Attachment: use_correct_taskqueue

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8649122 [details] [diff] [review]
use_correct_taskqueue

Review of attachment 8649122 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/platforms/SharedDecoderManager.cpp
@@ +186,5 @@
>  
>      nsRefPtr<SharedDecoderManager> self = this;
>      nsRefPtr<MediaDataDecoder::InitPromise> p = mDecoderInitPromise.Ensure(__func__);
>  
> +    // The mTaskQueue is flushable which can't be used in MozPromise.

same as H264Converter comment

::: dom/media/platforms/wrappers/H264Converter.cpp
@@ +167,5 @@
>      mMediaRawSamples.AppendElement(aSample);
>  
>      nsRefPtr<H264Converter> self = this;
>  
> +    // The mVideoTaskQueue is flushable which can't be used in MozPromise.

even if it wasn't flushable ; we wouldn't want to use it as it would cause thread-safety issues with the wrapped MediaDataDecoder which expects to control all that is going with its own task queue.

So that comment needs to be entirely removed because it's incorrect.

Comment 3

[Alfredo Yang (:alfredo)]

Thanks for quick review!

Comment 4

[Alfredo Yang (:alfredo)]

Attachment: use_correct_taskqueue

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/88df6aa8bf02

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/88df6aa8bf02