1195726 - Make langpacks work with remote storage

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect, P1)

Description

[Mathieu Pillard [:mat]]

Although Langpacks code was written to already use storage, since it's using the default storage class it will probably be broken with a remote storage (I haven't tested - I may be wrong).

It's probably just a matter of adjusting tests, views and models to use public_storage/private_storage correctly. Langpacks are automatically signed once uploaded, even if they are not active, and re-uses code from Webapp and and signing, so it should be straightforward.

Comment 1

[Mathieu Pillard [:mat]]

in mkt/langpacks/models.py:

                sign_app(storage.open(upload.path), self.file_path, ids)
            except SigningError:
                log.info('[LangPack:%s] Signing failed' % self.pk)
                if storage.exists(self.file_path):
                    storage.delete(self.file_path)

Using the default storage for upload.path would work, but we should use private_storage instead (FileUpload should be created using private_storage IIRC). In the except close though, it should be public_storage.

Some docs about the API: https://wiki.mozilla.org/Marketplace/LangPacks ; you can also try to download a manifest once a langpack is uploaded.

Comment 2

[Mathieu Pillard [:mat]]

Moving over to ashort since he has a PR dealing with that.

Comment 3

[Allen Short [:ashort]]

https://github.com/mozilla/zamboni/commit/4cb0a838a41da268b3a0891b5316afad9a4cc74f