Closed Bug 1195733 Opened 6 years ago Closed 2 years ago

UITelemetry counts hitting return on oneoff searches as an "unknown" source

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

RESOLVED INVALID
Tracking Status
firefox43 --- affected

People

(Reporter: gfritzsche, Unassigned)

Details

(Stuart Philp :sphilp from bug 1193892, comment #2)
> In the “UITelemetry” field for "oneoff" searches, hitting return on a
> default search seems to track as “google.unknown”, whereas clicking a
> non-default search provider shows it as “google.oneoff” 
> 
> "search-oneoff": {
>   "google.unknown": {
>     "key": {
>       "current": 5
>     }
>   },
>   "google.oneoff": {
>     "mouse": {
>       "current": 5
>     }
>   }
> }
Gijs, do you know who can look at this?
Flags: needinfo?(gijskruitbosch+bugs)
Florian is on PTO, so I will take a look either later today or tomorrow.

It's not 100% clear to me what the STR are here - is Google the default search provider, or are we talking about keyboard-navigating to a particular one-off search provider? I tried reading all of bug 1193892 comment #2, but I still didn't really understand what it was trying to test, sorry. :-\
Flags: needinfo?(gfritzsche)
Flags: needinfo?(gfritzsche) → needinfo?(sphilp)
Gijs, hitting enter with google as the default provider. So more formal steps:

1) With google as your default search provider (not tested on other defaults but it's likely the same), enter a search term in the search bar
2) Hit enter to initiate the search
3) View the oneoff telemetry and note that the UITelemetry search-oneoff field tracks this as "google.unknown"

Hitting enter with a default provider shouldn't track as a one-off?
Flags: needinfo?(sphilp)
(In reply to Stuart Philp :sphilp from comment #3)
> Gijs, hitting enter with google as the default provider. So more formal
> steps:
> 
> 1) With google as your default search provider (not tested on other defaults
> but it's likely the same), enter a search term in the search bar
> 2) Hit enter to initiate the search
> 3) View the oneoff telemetry and note that the UITelemetry search-oneoff
> field tracks this as "google.unknown"
> 
> Hitting enter with a default provider shouldn't track as a one-off?

I'm not the person using the UITelemetry, so I don't know - happy to implement whatever - but I would have expected it to track as google.searchbar. Is that wrong? How did you produce the foo.searchbar results in bug 1193892 comment #2 if this way doesn't work?
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(sphilp)
My train of thought here is essentially: hitting enter -> default, rather than a one-off non-default, search engine -> not ".oneoff" in UITelemetry (but ".searchbar").
UITelemetry is bwinton IIRC. It's not as important as the keyed histograms for search counts.
A little more detail:

On a new profile, after searching twice from the searchbar (one enter, one click) with the default (Yahoo), then a single Google one-off, then a single amazon one-off, we get the following in the countableEvents field:

"search": {
"searchbar": 3
},

"search-oneoff": {
"yahoo.unknown": {
  "key": {
    "current": 1
  },
  "mouse": {
    "current": 1
  }
},
"google.oneoff": {
  "mouse": {
    "current": 1
  }
},
"amazondotcom.oneoff": {
  "mouse": {
    "current": 1
  }
}
}


Thus, 
- The correct number of searches from the searchbar are recorded
- Everything in the "search-oneoff" field represents a search done from the searchbar, including the defaults, even thought these are technically not oneoffs

I then changed the default to Amazon, and got the following entry added to the packet:
"amazondotcom.unknown":{"key":{"current":1}}}}}

SO! It appears that:
- Anything in the "search-oneoff" field ending in ".unknown" indicates that a search was done from the searchbar WHEN THAT ENGINE WAS THE DEFAULT. 

This is actually kind of cool, since for urlbar searches all we know is the count from the session and what the default was, but we don't reflect that searches from the urlbar might have come from a different engine if it was changed mid-session.


Therefore, the current probe is precise and interpretable, although the nomenclature is sort of weird. If anyone thinks it's worth changing (I don't really), I would recommend changing the "search-oneoff" field to something like "searchbar-details," then replace ".unknown" with ".asdefault" so that oneoffs and default searches are easily distinguishable.
Great, sounds like this is actually is working ok and we can close this?
Flags: needinfo?(sphilp)
Sounds good to me.  Just to add more context (now that I've had a chance to think about it a little), when the probe was first implemented, we didn't show the current engine in the one-off list (because it was the default), so clicking that would have been impossible, and is likely untested/unhandled.  I'm not sure when that changed, but as long as we can interpret the new results, I'm happy.  ;)
Tracking the different actions makes a lot of sense, but it seems like it's conflating the "oneoff" nomenclature.

So it would be /nice/ to see "search-oneoff" be changed to something like like "searchbar-events", in addition to ".unknown" -> ".asdefault". Just for clarity, especially for anyone that comes across this in the future, as this is basic historical knowledge that would trip a new person up.

Something like:

"countableEvents": {
  "__DEFAULT__": {
    "search": {
      "searchbar": 14
    },
    "searchbar-events": {
      "yahoo.asdefault": {
        "key": {
          "current": 10
        }
      },
      "google.oneoff": {
        "mouse": {
          "current": 4
        }
      }
    }
  }
}
Component: General → Search

UITelemetry no longer exists, so we don't need this now.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.