1195741 - Context-menu open link commands don't work for links on bookmarks in sidebar

Status: RESOLVED DUPLICATE of bug 1159259

(Firefox :: Menus, defect)

Description

[errdk7]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150807085045

Steps to reproduce:

Created a web page of frequently used links, and opened it in sidebar.  
Right-click on a link and select "open link in new tab".


Actual results:

No action.  The right-click menu disappears, and command is ignored.


Expected results:

A new tab in the browser should have been created, and the link should have opened in it.

Additionally, "open link in new window" and "open link in new private window" show same behavior.

Comment 1

[Loic]

"opened it in sidebar"

How to do that in Firefox?

Comment 2

[errdk7]

(In reply to Loic from comment #1)
> "opened it in sidebar"
> 
> How to do that in Firefox?

Create a bookmark pointing at a web page.  Go to the "properties" of the bookmark, and place a checkmark in the "Load this bookmark in the sidebar".  Save the setting.

When you click on the bookmark, it will open in the sidebar.

Comment 3

[Loic]

Regression range:
good=2015-03-06
bad=2015-03-07
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0189941a3fd5&tochange=43fb1f92e8d4

Ian Moody — Bug 1133577 - Make context-menu open link/frame commands use messages to avoid unsafe CPOW warnings. r=mconley

Comment 4

[Loic]

Both non-e10s and e10s mode are affected.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for FF41 on ward as it is a regression.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Florian or jaws, might you have time to take a look at this? Minor regression but nice to have. Thanks!

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

I don't have time to look in to this right now.

Comment 8

[Florian Quèze [:florian]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #6)
> Florian or jaws, might you have time to take a look at this? Minor
> regression but nice to have. Thanks!

Not really. This is a duplicate of bug 1159259, which already has tracking-e10s+.
Initial investigation happened in bug 1159259 comment 5. Also, it's already an old regression, bug 1133577 landed in Firefox 38.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Florian, OK.    Would we then expect this to fail whether e10s is enabled or not?

Comment 10

[Florian Quèze [:florian]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #9)
> Would we then expect this to fail whether e10s is enabled or not?

It's broken when e10s is disabled too. (This was mentioned in bug 1159259 comment 2.)

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Florian: Yes, I did read the comments and understood that it is broken with or without e10s enabled. What I'm asking is why we think that's so, and why we'd classify this as an e10s issue. My goal here is to get someone to work on this at some point, since it's a known regression, or to figure out if we should stop tracking it entirely. Having several context menu options not work in the sidebar sound significant to me, whichever team's responsibility it should be.  I'll mention that over in bug 1159259 as well.

Comment 12

[Florian Quèze [:florian]]

It's an e10s issue because per bug 1159259 comment 5 the root cause is "the browser in the sidebar is not getting the content script browser/base/content.js loaded"

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

OK. Untracking then...