1195759 - Don't match against, and don't fail for, malformed share data (e.g., USA Today)

Status: RESOLVED WONTFIX

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

None of the extensions work from the USA Today application. 'Firefox', 'View Later' and 'Send Tab' all fail.

Steps to reproduce:

* Install the USA Today application
* Open an article
* Open a link in the article that opens in the mini-browser
* Hit the share button (bottom right) and share to Firefox (Firefox, View Later or Send Tab)

Expected: Things are shared.

Actual:

* Send Tab results in a black screen.
* View Later returns correctly but does not queue the page
* Firefox blinks the screen and then does not appear

This is most likely the USA Today application sharing the URL is some way we do not expect.

I think this is important to at least investigate because the same may happen with other apps.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Sharing from the USA Today app to for example the Safari Reading List also does not work. And the Safari 'Add to Bookmark' share option does not even appear.

This may just be a case of USA Today not correctly sharing a URL.

Comment 2

[Richard Newman [:rnewman]]

This might need logging. (On-device logging won't be easy: app containers.)

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This is what USA Today shares:

<NSExtensionItem: 0x136629900> - userInfo: {
    NSExtensionItemAttachmentsKey =     (
        "<NSItemProvider: 0x136629ea0> {types = (\n    \"public.plain-text\"\n)}"
    );
}

So that is unfortunate. And we should probably not even show up. I think we should tighten our extension activation rules and only show if there is a URL.