Closed
Bug 1195773
Opened 10 years ago
Closed 9 years ago
django deprecations: urls, reverse, dotted paths
Categories
(Webtools Graveyard :: Elmo, defect)
Webtools Graveyard
Elmo
Tracking
(firefox43 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | affected |
People
(Reporter: Pike, Assigned: Pike)
References
Details
Once we're on 1.8, let's do the invasive stuff for deprecations, this one is for
https://docs.djangoproject.com/en/1.8/releases/1.8/#django-conf-urls-patterns
and
https://docs.djangoproject.com/en/1.8/releases/1.8/#passing-a-dotted-path-to-reverse-and-url
patterns() dies, url() stops taking 'something.view.other', reverse() stops taking 'something.view.other'.
Which I find sad, but such is life. More context in https://groups.google.com/forum/#!searchin/django-developers/reverse/django-developers/zTGP3Bs6uKE/_UDdcU70l44J.
Comment 1•9 years ago
|
||
Commits pushed to develop at https://github.com/mozilla/elmo
https://github.com/mozilla/elmo/commit/f5b9a63cf879c6b50b084a192e6459167ac84eee
bug 1195773, urlpatterns are deprecated in django, dotted paths are deprecated
* replace urlpatterns with lists of url().
* remove dotted path from {% url %}
Also use the named urls consistently in python code.
And for the cases where it makes sense, use a namespace.
https://github.com/mozilla/elmo/commit/e9544148654fea06d973095378f8a4efffacab65
bug 1195773, follow-up, move remaining ClassView.as_view() into urls.py
| Assignee | ||
Comment 2•9 years ago
|
||
Marking this fixed, only a few things in shipping are left.
Assignee: nobody → l10n
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•