Closed
Bug 1195788
Opened 9 years ago
Closed 9 years ago
Reftest analyzer does not highlight differences on Windows 10
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: mchang, Assigned: xidorn)
References
Details
Attachments
(2 files, 1 obsolete file)
20.87 KB,
image/png
|
Details | |
2.89 KB,
patch
|
bas.schouten
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The reftest analyzer does not highlight pixel differences with nightly on Windows 10. Clicking show differences does nothing. STR: 1) Get a reftest failure in the reftest analyzer 2) click a failed test. 3) Click highlight differences 4) See that nothing is highlighted.
Reporter | ||
Comment 1•9 years ago
|
||
Screenshot from the reftest analyzer. An example reftest analyzer link: http://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mchang@mozilla.com-bf08c0c4dbed/try-linux64-debug/try_ubuntu64_vm-debug_test-reftest-1-bm116-tests1-linux64-build415.txt.gz&only_show_unexpected=1
Comment 2•9 years ago
|
||
Weird. Disabling hw acceleration fixes the problem to me which suggests that it's related to the d2d filter code.
Assignee: nobody → bas
Flags: needinfo?(bas)
Comment 3•9 years ago
|
||
Someone should check on a different version of Windows to see if it's only a Win10 issue
Reporter | ||
Comment 4•9 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #3) > Someone should check on a different version of Windows to see if it's only a > Win10 issue This works fine for me on Windows 7.
Comment 5•9 years ago
|
||
A reduced testcase for this filtergraph would be really really nice...
Flags: needinfo?(bas)
(In reply to Bas Schouten (:bas.schouten) from comment #5) > A reduced testcase for this filtergraph would be really really nice... If one doesn't show up, lets try without it.
I'm seeing this on Windows 10 for this failure: http://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-macosx64/1441997691/mozilla-inbound_snowleopard_test-reftest-bm106-tests1-macosx-build2754.txt.gz&only_show_unexpected=1 I'll have to go see if I still have any Windows 8/8.1 devices that I can test this on...
Assignee | ||
Comment 8•9 years ago
|
||
It seems to me the feComponentTransfer nodes c1->w1 and c2->w2 doesn't take any effect.
Assignee | ||
Comment 9•9 years ago
|
||
Well, not "doesn't take any effect", but has a wrong effect...
Assignee | ||
Comment 10•9 years ago
|
||
c1 and w2 are identical, and c2 and w1 are identical. It seems to me there is some mis-optimization happens. Bas, hopefully this information is enough for you to figure out what's wrong there.
Flags: needinfo?(bas)
Assignee | ||
Comment 11•9 years ago
|
||
So basically the formulas are w1 = img1 + ~img2 w2 = img2 + ~img1 c1 = ~w1 c2 = ~w2 Given c1 == w2 and c2 == w1, it seems some optimizer collapses the formulas together, so c1 = ~(img1 + ~img2) = ~img1 + img2 = w2 c2 = ~(img2 + ~img1) = ~img2 + img1 = w1 These equations look reasonable at first glance, but they are incorrect because arithmetic compositer clamps the result to [0..1] which is what the analyzer relies on.
Assignee | ||
Comment 12•9 years ago
|
||
Assignee | ||
Comment 13•9 years ago
|
||
Attachment #8701364 -
Attachment is obsolete: true
Attachment #8701364 -
Flags: review?(bas)
Attachment #8701370 -
Flags: review?(bas)
Assignee | ||
Comment 14•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a24aec074c9b
Comment 15•9 years ago
|
||
Comment on attachment 8701370 [details] [diff] [review] patch Review of attachment 8701370 [details] [diff] [review]: ----------------------------------------------------------------- Good catch!
Attachment #8701370 -
Flags: review?(bas) → review+
Assignee | ||
Comment 16•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/343ef099a285ee73e4fb6fa1a4f896da8f6cc0f2 Bug 1195788 - Set arithmetic composite clamp to true for D2D filter node. r=bas
Comment 17•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/343ef099a285
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Assignee | ||
Comment 18•9 years ago
|
||
Comment on attachment 8701370 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: unknown, hw acceleration related issue [User impact if declined]: may see incorrect rendering from svg filter [Describe test coverage new/current, TreeHerder]: new test added with the patch [Risks and why]: low risk. This patch just sets the clamp property on the d2d impl which is required by the svg filter spec. So it doesn't affect anything other than windows hw accel part. And this patch itself is simple and straightforward enough. [String/UUID change made/needed]: n/a
Attachment #8701370 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•9 years ago
|
Comment 19•9 years ago
|
||
Comment on attachment 8701370 [details] [diff] [review] patch With test! Thanks :)
Attachment #8701370 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
Comment 20•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/df26cbee3d0c
You need to log in
before you can comment on or make changes to this bug.
Description
•