Closed Bug 1195797 Opened 9 years ago Closed 9 years ago

Remote tabs panel should show a spinner while syncing instead of a blank panel

Categories

(Firefox for iOS :: Home screen, defect)

Product:
Firefox for iOS
Component:
Home screen
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: dhenein, Assigned: fluffyemily)

Details

Attachments

(1 file)

Pull request
47 bytes, text/x-github-pull-request
st3fan
: review+
dhenein
: ui-review+
Details | Review 
      No description provided.
Assignee: nobody → etoop
Status: NEW → ASSIGNED
Attached file Pull request — 

        Attachment #8649335 -
        Flags: ui-review?(dhenein)

        Attachment #8649335 -
        Flags: review?(sarentz)

    
    

    
  
Comment on attachment 8649335 [details] [review]
Pull request

Looks great, thanks! Will this show any time we don't have local data to present? I'm certain I've seen the white panel after I'd synced once before.

        Attachment #8649335 -
        Flags: ui-review?(dhenein) → ui-review+

    
    

    
  
Comment on attachment 8649335 [details] [review]
Pull request

LGTM

        Attachment #8649335 -
        Flags: review?(sarentz) → review+

    
    

    
  
Looks like this is good to go - I'm going to merge it in for the build tonight
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: