Closed Bug 1195857 Opened 4 years ago Closed 4 years ago
Author Specified Rules to take a const arg, to remove need for hacky const _casts
When reviewing bug 1182414, I noticed we generally do a hacky const_cast on "this" before calling HasAuthorSpecifiedRules (in existing code), since HasAuthorSpecifiedRules takes a non-const nsIFrame*. There's no reason it has to be this way; HasAuthorSpecifiedRules can just take a const nsIFrame*, and then we can do away with all these const_casts.
My patch for this layers on top of jwatt's patch for bug 1182414 (which touches the same call-sites).
Depends on: 1182414
Comment on attachment 8649365 [details] [diff] [review] fix v1 Looks good. Free to land this before my patch.
Attachment #8649365 - Flags: review?(jwatt) → review+
OK, thanks -- landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/50b36c5e9060
4 years ago
You need to log in before you can comment on or make changes to this bug.