1195884 - 'will-change: will-change' should be rejected

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Benoit Girard (:BenWa)]

As mentioned on www-style, we should be rejecting 'will-change: will-change':
http://www.w3.org/TR/css-will-change-1/#will-change

Comment 1

[Benoit Girard (:BenWa)]

Attachment: MozReview Request: Bug 1195884 - Reject CSS 'will-change: will-change' for spec compliance. r=dholbert

Bug 1195884 - Reject CSS 'will-change: will-change' for spec compliance. r=dbaron

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8649415 [details]
MozReview Request: Bug 1195884 - Reject CSS 'will-change: will-change' for spec compliance. r=dholbert

https://reviewboard.mozilla.org/r/16399/#review14721

::: layout/style/test/property_database.js:6387
(Diff revision 1)
> -    invalid_values: [ "none", "all", "default", "auto, scroll-position", "scroll-position, auto", "transform scroll-position", ",", "trailing," ]
> +    invalid_values: [ "none", "all", "default", "auto, scroll-position", "scroll-position, auto", "transform scroll-position", ",", "trailing,", 'will-change', 'transform, will-change' ]

Please use double-quotes around your new strings here, for consistency with the rest of this line.

Comment 3

[Daniel Holbert [:dholbert]]

Also, the commit message needs s/dbaron/dholbert/.

r=me with that & comment 2 fixed. (not familiar enough with reviewboard yet to know how to express "tweak this in the commit message", and "r=me with the following fixed")

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 8649415 [details]
MozReview Request: Bug 1195884 - Reject CSS 'will-change: will-change' for spec compliance. r=dholbert

Bug 1195884 - Reject CSS 'will-change: will-change' for spec compliance. r=dholbert

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 8649415 [details]
MozReview Request: Bug 1195884 - Reject CSS 'will-change: will-change' for spec compliance. r=dholbert

https://reviewboard.mozilla.org/r/16399/#review14727

Ship It!

Comment 6

[Benoit Girard (:BenWa)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/27840230efdf59d23b3c2b4cb950857d0e9b0952
changeset:  27840230efdf59d23b3c2b4cb950857d0e9b0952
user:       Benoit Girard <[e-mail]>
date:       Tue Aug 18 16:07:01 2015 -0400
description:
Bug 1195884 - Reject CSS 'will-change: will-change' for spec compliance. r=dholbert

Comment 7

[Sebastian Zartner [:sebo]]

I added a note about that at https://developer.mozilla.org/en-US/docs/Web/CSS/will-change. It needs to be adjusted once this is shipped.

Sebastian

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/27840230efdf

Comment 9

[Sebastian Zartner [:sebo]]

Thanks for the fix! I can confirm that you can't set 'will-change' as value anymore.

I updated the footnote at https://developer.mozilla.org/en-US/docs/Web/CSS/will-change accordingly.

Sebastian