Closed Bug 1195949 Opened 5 years ago Closed 5 years ago

Remove the key image in the context menu

Categories

(Toolkit :: Password Manager, defect)

defect
Not set
normal
Points:
2

Tracking

()

VERIFIED FIXED
mozilla43
Iteration:
43.2 - Sep 7
Tracking Status
firefox41 --- unaffected
firefox42 --- verified
firefox43 --- verified

People

(Reporter: rfeeley, Assigned: rittme)

References

Details

Attachments

(2 files)

Attached file keys.zip
Use black key in they contextual menu, and switch to white when the row has focus. Beloved ZIP file attached.
Assignee: nobody → bernardo
Status: NEW → ASSIGNED
Iteration: --- → 43.2 - Sep 7
Points: --- → 2
Flags: qe-verify+
OS: Unspecified → All
Hardware: Unspecified → All
Version: unspecified → Trunk
Speaking with my manager, Stephen Horlander, we decided that the key icon is not needed at all. Should I file a different bug or edit this one?
Flags: needinfo?(bernardo)
Summary: Improve key images in contextual menu → Remove the key image in the context menu
Yes, renaming it would be enough. Thank you.
Flags: needinfo?(bernardo)
Bug 1195949 - Removed key icon from context menu fill. r=MattN
Attachment #8655140 - Flags: review?(MattN+bmo)
Comment on attachment 8655140 [details]
MozReview Request: Bug 1195949 - Removed key icon from context menu fill. r=MattN

https://reviewboard.mozilla.org/r/17837/#review15925

Thanks. Please request uplift for this.
Attachment #8655140 - Flags: review?(MattN+bmo) → review+
and set the status flags too please.
Comment on attachment 8655140 [details]
MozReview Request: Bug 1195949 - Removed key icon from context menu fill. r=MattN

Approval Request Comment
[Feature/regressing bug #]: Bug 433238 added a new item to the context menu, with a key icon to the left. We want to remove this key icon.
[User impact if declined]: Users will have a key icon at the new context menu item, but this icon will not be there anymore at the next release.
[Describe test coverage new/current, TreeHerder]: Manual testing was made for this small visual change.
[Risks and why]: Low risk because its only removing some CSS styling added on bug 433238.
[String/UUID change made/needed]:none
Attachment #8655140 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/05e8c86d5728
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment on attachment 8655140 [details]
MozReview Request: Bug 1195949 - Removed key icon from context menu fill. r=MattN

Low risk, polish, taking it.
Attachment #8655140 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Went through verification using the following builds:
- https://archive.mozilla.org/pub/firefox/nightly/2015-09-08-03-02-03-mozilla-central/
- https://archive.mozilla.org/pub/firefox/nightly/2015-09-08-00-40-20-mozilla-aurora/

OS's Used:

- OSX 10.10.5 x64 -> PASSED
- Win 10 x64 (VM) -> PASSED
- Ubuntu 14.04.3 -> PASSED

Went through the context menu and ensured that the "key" icon that was next to "Fill login" as been removed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.