1195955 - Findbar displays wrong number of found strings if a page contains iframe above current found string AND the iframe isn't visible on the screen

Status: RESOLVED WORKSFORME

(Toolkit :: Find Toolbar, defect, P5)

Description

[arni2033]

Attachment: Findbar displays wrong number of found strings if a page contains iframe above current found string AND the iframe isn't visible on the screen.webm

STR:   (Win7, Nightly 43.0a1 (2015-08-18))
1. Open   data:text/html,<iframe style="margin-bottom:4000px" src="data:text/html,L L"></iframe><br>L L
in a new tab
2. Press Ctrl+F to open findbar
3. Type "L" without quotes into findbar
4. Press Enter 4 times.

RESULT        I get these messages in findbar:
              "1 of 2 matches", "2 of 2 matches", "3 of 4 matches", "4 of 4 matches"

EXPECTATIONS  Messages should display the right number of found strings:
              "1 of 4 matches", "2 of 4 matches", "3 of 4 matches", "4 of 4 matches"

Try the same steps with this URL to see that the real placement of elements in HTML is irrelevant:
data:text/html,<div style="background: tan; position:absolute; top:8000px;">L L div</div>L L start<br><iframe style="margin:4000px 0px" src="data:text/html,L L iframe"></iframe><br>L L end

Comment 1

[arni2033]

Just click "URL" without copy-pasting "data:" links. Watch attached video if you failed to reproduce.

I found this bug on http://venturebeat.com/2015/07/11/here-are-the-12-most-influential-programmers-working-today/?obref=obinsite while searching in comments.

Comment 2

[Mike de Boer [:mikedeboer]]

You're right, that looks like a bug in the counter code. Thanks for the useful easy-to-reproduce testcase! It makes it so much more easier to find a good solution.

Leaving the n-i as a marker to work on this when I find time.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Comment 4

[Neil Deakin]

This seems to work ok now.