[Control Center] More Information button should be in the subpanel

VERIFIED FIXED in Firefox 42

Status

()

defect
P1
normal
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: tanvi, Assigned: dao)

Tracking

42 Branch
Firefox 43
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox41 wontfix, firefox42 verified, firefox43 verified)

Details

(Whiteboard: [fxprivacy])

Attachments

(2 attachments)

When a user opens the control center and wants to learn more about their connection, they click the right arrow and go into the subpanel.  The subpanel should then include the "More Information" button if they want to learn more about the certificate and the website they are visiting.  It is not intuitive to go back to the main view of Control Center and then hit More Information.
Needinfo'ing Aislinn since this requires some UX consideration
Flags: needinfo?(agrigas)
Priority: -- → P3
Posted patch patchSplinter Review
I was just going to file a bug on this. The Identity panel has three sections: Security, Tracking Protection and Permissions, and then there's the "More Information" button that opens Page Info > Security. The Tracking Protection and Permissions sections are optional, but when they're present they disconnect the "More Information" button from the Security section, making the button misleading.

I think this is essentially a bug in the original design (http://people.mozilla.org/~shorlander/mockups/Control-Center/Control-Center-i01-02.html) as it didn't seem to take into account what kind of information this button would show.

The Security section already has an expander for showing more information. As comment 0 says, putting the button in the sub view, basically as a "yet more information" button, is more intuitive.
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8651011 - Flags: ui-review?(shorlander)
Attachment #8651011 - Flags: review?(tanvi)
Comment on attachment 8651011 [details] [diff] [review]
patch

>@@ -154,11 +149,12 @@
>                 label="&identity.disableMixedContentBlocking.label;"
>                 accesskey="&identity.disableMixedContentBlocking.accesskey;"
>                 oncommand="gIdentityHandler.disableMixedContentProtection()"/>
>         <button when-mixedcontent="active-loaded"
>                 label="&identity.enableMixedContentBlocking.label;"
>                 accesskey="&identity.enableMixedContentBlocking.accesskey;"
>                 oncommand="gIdentityHandler.enableMixedContentProtection()"/>
>       </vbox>
>+
>     </panelview>
>   </panelmultiview>
> </panel>

ignore this change...
Comment on attachment 8651011 [details] [diff] [review]
patch

Review of attachment 8651011 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Dão Gottwald [:dao] from comment #2)
> The Security section already has an expander for showing more information.
> As comment 0 says, putting the button in the sub view, basically as a "yet
> more information" button, is more intuitive.

Makes sense to me, patch looks good.
Attachment #8651011 - Flags: ui-review?(shorlander) → ui-review+
Comment on attachment 8651011 [details] [diff] [review]
patch

The More Information button takes you to a view with many tabs/sections.  Security is one of them, but Permissions is another.  That whole UI really needs a makeover.  In the meantime, More Information may be relevant to both the main panel and the security subpanel.  Should we put the button there twice, once in the main view and once in the security view?  If clicked in the security view, take the user to the security pane?  I think this needs a bit more thought from UX.

As for review, you probably want to ask a browser peer.  Does the css removed from browser/themes/shared/controlcenter/panel.inc.css need to be replicated somewhere else?
Attachment #8651011 - Flags: review?(tanvi)
(In reply to Tanvi Vyas [:tanvi] from comment #5)
> Should we put the button there twice, once in the main view and once in the security view?  If clicked in
> the security view, take the user to the security pane?

Once we have the permissions subview then that will mostly replace the need to link to the Page Info permissions pane (except for plug-ins). In the meantime it may make sense to keep it there pointing to a different Page Info tab

> As for review, you probably want to ask a browser peer.

Since Dão is a browser peer his request review from a non-peer is sufficient as long as the reviewer is comfortable reviewing.
Comment on attachment 8651011 [details] [diff] [review]
patch

(In reply to Tanvi Vyas [:tanvi] from comment #5)
> Comment on attachment 8651011 [details] [diff] [review]
> patch
> 
> The More Information button takes you to a view with many tabs/sections.
> 
> Security is one of them, but Permissions is another.

Tools -> Page Info is the primary entry point for that UI, though. We added the button because we thought it might be a nice shortcut for technical users to get all the security information. The panel only showed security information at that time, so there was no room for misunderstanding. In no way did we want users to open Page Info's Security section in order to switch to a different section.

> That whole UI really
> needs a makeover.  In the meantime, More Information may be relevant to both
> the main panel and the security subpanel.  Should we put the button there
> twice, once in the main view and once in the security view?

No. :( That would add to the weirdness of this UI rather than clearing it up, which was my goal here.
Attachment #8651011 - Flags: review?(MattN+bmo)
I DO think it makes sense to anchor to the corresponding tab if the user clicks More info button from the subpanel. 

The more info modal isn't getting any major re-design most likely for 43 given the amount we already have on our plate unfortunately though we do think it could use some cleanup -especially around permissions. 

We need to keep the Permissions tab of this modal since if there are more permissions then will fit in the sub-panel view (which is fixed height), we open the More info panel for the overflow.
Flags: needinfo?(agrigas)
We will plan add a More Info button to the relevant subpanels for 43.
Aislinn, just to be clear, the decision is to remove the More Info button from the main panel and put it in all the relevant subpanels, ensuring that it links to the right tab for that subpanel?
Flags: needinfo?(agrigas)
(In reply to Tanvi Vyas [:tanvi] from comment #10)
> Aislinn, just to be clear, the decision is to remove the More Info button
> from the main panel and put it in all the relevant subpanels, ensuring that
> it links to the right tab for that subpanel?

No it is to have it on both panels as it includes content that doesnt relate to any section in the control panel (for example the General and Media tabs). We still need to provide access to those from the first panel. For sub-panels we'll add the more info button and link to the appropriate tab inside the modal.
Flags: needinfo?(agrigas)
(In reply to agrigas from comment #11)
> (In reply to Tanvi Vyas [:tanvi] from comment #10)
> > Aislinn, just to be clear, the decision is to remove the More Info button
> > from the main panel and put it in all the relevant subpanels, ensuring that
> > it links to the right tab for that subpanel?
> 
> No it is to have it on both panels as it includes content that doesnt relate
> to any section in the control panel (for example the General and Media
> tabs). We still need to provide access to those from the first panel.

The General and Media tabs are largely irrelevant for most users. As said before, Tools -> Page Info is the primary entry point for that UI (the context menu is another one). Let's not clutter up the identity panel / control center with this.

> For sub-panels we'll add the more info button and link to the appropriate tab inside
> the modal.

Agreed.
(In reply to Dão Gottwald [:dao] from comment #12)
> (In reply to agrigas from comment #11)
> > (In reply to Tanvi Vyas [:tanvi] from comment #10)
> > > Aislinn, just to be clear, the decision is to remove the More Info button
> > > from the main panel and put it in all the relevant subpanels, ensuring that
> > > it links to the right tab for that subpanel?
> > 
> > No it is to have it on both panels as it includes content that doesnt relate
> > to any section in the control panel (for example the General and Media
> > tabs). We still need to provide access to those from the first panel.
> 
> The General and Media tabs are largely irrelevant for most users. As said
> before, Tools -> Page Info is the primary entry point for that UI (the
> context menu is another one). Let's not clutter up the identity panel /
> control center with this.
> 
> > For sub-panels we'll add the more info button and link to the appropriate tab inside
> > the modal.
> 
> Agreed.

Ok - I'm good with that. Was only keeping it because I thought we needed to continue providing access to those area. If there is a redundant way to get there - sub-panel only approach works. Will update the design work.
Will update the upcoming design work to include this change
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Iteration: --- → 43.2 - Sep 7
Flags: qe-verify?
Patch still needs review and landing before this can be resolved...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: qe-verify? → qe-verify+
Iteration: 43.2 - Sep 7 → ---
(In reply to Dão Gottwald [:dao] from comment #15)
> Patch still needs review and landing before this can be resolved...

We shouldnt just solve this with a patch - we should have the design updated since we want to make sure we adjust for the right fixed height of each panel with this change. We are adjusting that for 43 with the new addition of the permissions section so I would like to incorporate this change then and not beforehand.
The height seemed to adjust automatically and not need manual changes from what I can tell. Am I missing something?
(In reply to Dão Gottwald [:dao] from comment #17)
> The height seemed to adjust automatically and not need manual changes from
> what I can tell. Am I missing something?

When we add permissions and logins sections - we're fixing the height of the sub-panel for that section so we don't have a ton of resizing when transitioning into the sub-panel.
Ok, but this patch should be good to go before that. It's a self-contained subset of the work that will need to be done anyway.
Attachment #8651011 - Flags: review?(jaws)
Comment on attachment 8651011 [details] [diff] [review]
patch

Review of attachment 8651011 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, hopefully the person who re-implements the footer buttons when we need them knows that they can get pull the CSS for it out of hg history or reverting part of this patch.
Attachment #8651011 - Flags: review?(jaws)
Attachment #8651011 - Flags: review?(MattN+bmo)
Attachment #8651011 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/8eacc2c5ba4e
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Iteration: --- → 43.2 - Sep 7
Blocks: 1170759
QA Contact: paul.silaghi
More Information button is in the subpanel now and opens the Page Info/Security window.
Verified fixed FF 43.0a1 (2015-08-30) Win7, Ubuntu 14.04, OS X 10.10.
Status: RESOLVED → VERIFIED
Comment on attachment 8651011 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1170759
[User impact if declined]: the security sub view was implemented in bug 1170759 for Firefox 41. I think it makes sense to uplift this in order to reduce UI churn between releases.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: straightforward change, low risk
[String/UUID change made/needed]:
Attachment #8651011 - Flags: approval-mozilla-aurora?
Attachment #8654949 - Flags: approval-mozilla-beta?
The styling of this button is incorrect - it should have remained as it was styled before it was moved to the sub-panel.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Iteration: 43.2 - Sep 7 → ---
(In reply to agrigas from comment #26)
> The styling of this button is incorrect - it should have remained as it was
> styled before it was moved to the sub-panel.

Does that mean it should remain a full footer button?
(In reply to agrigas from comment #26)
> The styling of this button is incorrect - it should have remained as it was
> styled before it was moved to the sub-panel.

That doesn't work out. There's a conditional separator and further content related to mixed content below it. Not sure if there are plans to cut that content back to only identity information. If so the button can be styled again like a footer at that point.
(In reply to Stephen Horlander [:shorlander] from comment #27)
> (In reply to agrigas from comment #26)
> > The styling of this button is incorrect - it should have remained as it was
> > styled before it was moved to the sub-panel.
> 
> Does that mean it should remain a full footer button?

Given you designed this - what do you think visually? I'll let you make the call.
I've noticed (Nightly 43.0a1 x64 2015-08-31)
that, in case of Mixed Content, the "More Information" button appears on top(below the seperator),
instead of the bottom of the control center.
Screenshot comparison: https://i.imgur.com/YWjkDWA.jpg
(In reply to Kostas from comment #30)
> I've noticed (Nightly 43.0a1 x64 2015-08-31)
> that, in case of Mixed Content, the "More Information" button appears on
> top(below the seperator),
> instead of the bottom of the control center.
> Screenshot comparison: https://i.imgur.com/YWjkDWA.jpg

The button should always be at the bottom of the panel. The visual style should be like this:
https://www.dropbox.com/s/z7n0lda2cr5zaci/Screenshot%202015-08-31%2016.32.09.png?dl=0
Comment on attachment 8654949 [details] [diff] [review]
patch for mozilla-beta

Based on the discussion in the bug (see comment 31), this patch may need to be modified to change the position of the "More Information" button. Please re-nominate the updated patch when ready.
Attachment #8654949 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
(In reply to Ritu Kothari (:ritu) from comment #32)
> Comment on attachment 8654949 [details] [diff] [review]
> patch for mozilla-beta
> 
> Based on the discussion in the bug (see comment 31), this patch may need to
> be modified to change the position of the "More Information" button. Please
> re-nominate the updated patch when ready.

The styling should also match the screenshot above.
Depends on: 1202122
No longer depends on: 1202122
Filed bug 1202279, bug 1202280
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Depends on: 1202279, 1202280
Resolution: --- → FIXED
Iteration: --- → 43.2 - Sep 7
Dao, what is the plan here? Should I wait for the two dependencies before accepting this uplift? Thanks
Flags: needinfo?(dao)
My priority would be to get rid of the prominently placed button in the main section of the panel to reduce the UI churn between upcoming releases, so I think this would be fine to uplift even without those followups, but I don't feel strongly either way.
Flags: needinfo?(dao)
(In reply to Dão Gottwald [:dao] from comment #34)
> Filed bug 1202279, bug 1202280
Marking this bug as verified on FF 43.0a1 (2015-09-08). Work continues in the follow-up bugs.
Status: RESOLVED → VERIFIED
Comment on attachment 8651011 [details] [diff] [review]
patch

OK, let's take it then!
Attachment #8651011 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Paul Silaghi, QA [:pauly] from comment #37)
> Marking this bug as verified on FF 43.0a1 (2015-09-08). Work continues in
> the follow-up bugs.
Verified fixed 42.0a2 (2015-09-11) Win 7
Now we lost completely the 'More Info' button on about:home - https://wiki.mozilla.org/File:Chrome.jpg
Thoughts?
Flags: needinfo?(dao)
(In reply to Paul Silaghi, QA [:pauly] from comment #41)
> Now we lost completely the 'More Info' button on about:home -
> https://wiki.mozilla.org/File:Chrome.jpg
> Thoughts?

Page Info doesn't provide useful security info for about:home, so for that the button wasn't useful in the first place.
Flags: needinfo?(dao)
Priority: P3 → P1
You need to log in before you can comment on or make changes to this bug.