1196089 - Strings passed to setTimeout/Interval do not have an introductionType set

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[onefling8]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150511103946

Steps to reproduce:

1. point the browser to http://makermade.github.io/jstest1/
2. wait the content loaded
3. click Developer > Debugger, and click the emulate.js from the site




Actual results:

the Debugger does not show the source code of emulate.js


Expected results:

the Debugger should show the source code of emulate.js.
I have tried with IE/safari/chrome, all of them work well.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Interesting, it looks like we are showing a source eval'd by the "main" source rather than that "main" source.

I get

> animate(55)

as the source contents, and if you right click and grab the source's reported URL and open that in a new tab, you get a different source content, but this line near the bottom:

> setTimeout('animate('+n+')',50);

Which is where I suspect the source that is actually shown is coming from.

Most likely a bug with our filtering of eval'd sources + somewhere where we are still keying by URL and getting the wrong thing.

Comment 2

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1196089 - Treat script sources introduced by DOM timers as anonymous. r=davidwalsh!

Comment 3

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1196089 - Treat javascript: scripts as anonymous sources. r=davidwalsh!

Depends on D83410

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b2c7b2f3222
Treat script sources introduced by DOM timers as anonymous. r=davidwalsh
https://hg.mozilla.org/integration/autoland/rev/5202ada0cf1d
Treat javascript: scripts as anonymous sources. r=davidwalsh

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4b2c7b2f3222
https://hg.mozilla.org/mozilla-central/rev/5202ada0cf1d