1196112 - Remove DecodedStream::mMonitor

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Bug 1195632 adds a worker thread to DecodedStream which allows us to do async programming and remove the monitor.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1feb93013f2f

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1196112. Part 1 - ensure all members except |mShuttingDown| and |mOutputStreamManager| are accessed on the worker thread only.

Bug 1196112. Part 1 - ensure all members except |mShuttingDown| and |mOutputStreamManager| are accessed on the worker thread only.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1196112. Part 2 - Remove DecodedStream::mMonitor.

Bug 1196112. Part 2 - Remove DecodedStream::mMonitor.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8651690 [details]
MozReview Request: Bug 1196112. Part 1 - ensure all members except |mShuttingDown| and |mOutputStreamManager| are accessed on the worker thread only.

https://reviewboard.mozilla.org/r/16961/#review15051

Ship It!

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8651691 [details]
MozReview Request: Bug 1196112. Part 2 - Remove DecodedStream::mMonitor.

https://reviewboard.mozilla.org/r/16963/#review15053

Ship It!

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c678e1317fa0
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2eb913e58c9

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out for being the likely cause of bug 1197977.
https://hg.mozilla.org/integration/mozilla-inbound/rev/49879f964c82

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Also looks related:
https://treeherder.mozilla.org/logviewer.html#?job_id=13230495&repo=mozilla-inbound

Maybe a stretch (filing it as a new bug just in case):
https://treeherder.mozilla.org/logviewer.html#?job_id=13231103&repo=mozilla-inbound

Comment 10

[Ryan VanderMeulen [:RyanVM]]

This wasn't at fault. It can re-land at your convenience. But please do investigate bug 1197977 as I suspect it's one of the patches you landed today.

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Sure, please re-land it. I am doing some try pushes to locate the suspicious changesets.

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0b946df6a24
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce19ea0695c2

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b0b946df6a24
https://hg.mozilla.org/mozilla-central/rev/ce19ea0695c2