On our internal mailing list we recently had the topic about possible version conflicts of python packages even when your application is listing all deps as strict versions. Now it hit us in Mozmill 220.127.116.11 with mozlog again. Here is how our setup.py file looks like: deps = ['jsbridge == 18.104.22.168', 'ManifestDestiny == 0.5.7', 'mozinfo == 0.7', 'mozrunner == 5.35', 'mozversion == 1.0', ] It's kinda clear which versions it wants, and as a customer I would trust that libraries are handling their internal dependencies gracefully and keep backward compatibility. But here mozrunner fails and does not install mozlog 2.x but the incompatible version 3.0: ManifestDestiny==0.5.7 argparse==1.2.1 blessings==1.6 jsbridge==22.214.171.124 mozcrash==0.15 mozdevice==0.46 mozfile==1.2 mozinfo==0.7 mozlog==3.0 mozmill==126.96.36.199 moznetwork==0.27 mozprocess==0.22 mozprofile==0.26 mozrunner==5.35 mozversion==1.0 mutt==0.1 wsgiref==0.1.2 Even we do not use some of the dependencies directly I would go ahead and simply add them to our list so we can set an upper version bound for used mozbase packages.
Created attachment 8649708 [details] [diff] [review] 0001-Bug-1196122-Release-Mozmill-188.8.131.52-with-fixes-for-.patch This fixes the dependency conflicts and allows our mozmill 2.0 hotfix branch to work again. It's unfortunate to have to do that but right now there is simply absolutely no compatibility for older mozbase releases. Everything can break for them. I put a couple of possible reviewers on that attachment. So if you feel confident and come first, please do the review. Thanks.
Comment on attachment 8649708 [details] [diff] [review] 0001-Bug-1196122-Release-Mozmill-184.108.40.206-with-fixes-for-.patch Looks good to me.
Attachment #8649708 - Flags: review?(j.parkouss) → review+
Comment on attachment 8649708 [details] [diff] [review] 0001-Bug-1196122-Release-Mozmill-220.127.116.11-with-fixes-for-.patch Review of attachment 8649708 [details] [diff] [review]: ----------------------------------------------------------------- Thank you Julien. I will get it merged in a minute.
https://github.com/mozilla/mozmill/commit/890c30d2c2d7d8bc9ff3997d284bdcaa9d4ef5c8 (hotfix-2.0) Tagged 18.104.22.168 release: https://github.com/mozilla/mozmill/commits/22.214.171.124 Uploaded to pypi: Submitting dist/mozmill-126.96.36.199.tar.gz to https://pypi.python.org/pypi Server response (200): OK
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.