Closed Bug 1196146 Opened 6 years ago Closed 5 years ago

Allow zoomed view to ride the trains

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(firefox45 fixed)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: domivinc, Assigned: domivinc)

References

Details

Attachments

(1 file)

Currently the zoomed view is available in nightly build only. We will have to make different changes in order to get it in Aurora. This bug is used to keep a log of all those changes.

1- the code changes to remove the nightly build flag (see bug 1182809 comment 1 to get an idea of the changes).

2- change the default ON or OFF for the “Magnify small areas“ user preference in the menu (see bug 1192075 for details). The current value in nightly is true (zoomed view is enabled by default):
pref("ui.zoomedview.enabled", true); in mobile.js

3- if we decided to start with the OFF option in the previous point 2, keep the possibility to set it ON on a next release. In this case, it will be nice to keep a flag for the users who already manually switch ON then OFF. It will avoid to bother them when they will install the new release with the default set to ON.
Domivinc, please CC' myself and Karen (or even a NI flag would be good) in these types of bugs in the future.

Karen, thoughts on this? take a peek at https://bugzilla.mozilla.org/show_bug.cgi?id=1192075#c30 for some context.

TBH, I'm on the fence about leaving it pref'd ON by default in Nightly. I see some value in getting it out there. But until we land bug 1135369 and all the other related ones around "not showing up in the right places". I'm not sure a lot of the feedback will be terribly useful.
Flags: needinfo?(krudnitski)
Anthony - I think that until we have a better handle on when it's showing up (balance usefulness with being annoying), I don't want this preffed on in aurora. I'd rather err on 'not annoying'.

But I *think* from some other bug comments, we're making progress on that front??
Flags: needinfo?(krudnitski)
I agree - for purposes of this bug let's not resolve this for now. 

But we can leave this bug open for when we start tracking this feature passed Nightly.

Yes, we're making progress on that front. Especially after bug 1191041 landed. It's appearing a lot less frequently (in a good way!)
Dominique, could you take a look into this?
Flags: needinfo?(domivinc)
Assignee: nobody → domivinc
Flags: needinfo?(domivinc)
Comment on attachment 8685602 [details] [diff] [review]
patch-10112015 1-Bug_1196146___Activation_of_the_zoomed_view_in_Aurora___r_mcomella.patch

Review of attachment 8685602 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

This still be disabled via ui.zoomedview.enabled, right? We should probably make sure that preference works as expected.
Attachment #8685602 - Flags: review?(michael.l.comella) → review+
The preference ui.zoomedview.enabled can be changed using about:config or in the Firefox menu "Accessibility" -> "Magnify small areas".
The default value is true. By default, the zoomed view is displayed after a click in a cluster of links.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=79109bc168ba
Michael, all the tests are green. 
Did you ask for the green light from Karen and Anthony to push the zoomed view functionality on the Aurora/Beta/Production train?
Flags: needinfo?(michael.l.comella)
(In reply to Dominique Vincent [:domivinc] from comment #8)
> Michael, all the tests are green. 
> Did you ask for the green light from Karen and Anthony to push the zoomed
> view functionality on the Aurora/Beta/Production train?

Anthony and I decided once the bugs on the meta bug 1198463 were complete, we'd let it ride the trains from Nightly (i.e. no uplift). There's still bug 1222638 but I added that afterwards as an engineering want so it's not strictly necessary.

In other words, we're good to land this! :)
Flags: needinfo?(michael.l.comella)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6cbadfaa418a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Summary: Activation of the zoomed view in Aurora → Allow zoomed view to ride the trains
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.