1196254 - Contextual hint shown the first time tracking protection is triggered is cut off in landscape

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: Hi7LugL.png

Tested with:
Device: HTC Desire HD (Android 2.3.5) , Samsung galaxy R (Android 2.3.4)
Steps to reproduce:
1. Open private browsing in landscape
2. Go to https://espn.go.com

Expected results:
- A doorhanger is correctly displayed with information about what tracking protection means.

Actual results:
- The doorhanger is cut off in landscape. "Got it" button is not visible

Note:
- Tested with a Samsung S5 (Android 4.4): http://i.imgur.com/eFoixuw.png

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1196254 - Contextual hint shown the first time tracking protection is triggered is cut off in landscape r?sebastian

Bug 1196254 - Contextual hint shown the first time tracking protection is triggered is cut off in landscape r?sebastian

Comment 2

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4189e327720

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8651047 [details]
MozReview Request: Bug 1196254 - Contextual hint shown the first time tracking protection is triggered is cut off in landscape r?sebastian

https://reviewboard.mozilla.org/r/16829/#review15151

Ship It!

Comment 4

[Martyn Haigh (:mhaigh)]

url:        https://hg.mozilla.org/integration/fx-team/rev/aec72f4f3fa82e6e57da1e16a93d38ff33b659a9
changeset:  aec72f4f3fa82e6e57da1e16a93d38ff33b659a9
user:       Martyn Haigh <[e-mail]>
date:       Fri Aug 21 15:55:34 2015 +0100
description:
Bug 1196254 - Contextual hint shown the first time tracking protection is triggered is cut off in landscape r=sebastian

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aec72f4f3fa8

Comment 6

[Teodora Vermesan (:TeoVermesan)]

Attachment: PBzVCJX.png

verified as fixed using:
Device: HTC Desire HD (Android 2.3.5)
Build: Firefox for Android 43.0a1 (2015-09-02)

Comment 7

[:Margaret Leibovic]

Should we uplift this to 42?

Comment 8

[Martyn Haigh (:mhaigh)]

Comment on attachment 8651047 [details]
MozReview Request: Bug 1196254 - Contextual hint shown the first time tracking protection is triggered is cut off in landscape r?sebastian

Approval Request Comment
[Feature/regressing bug #]: 1175970
[User impact if declined]: Some users may not see all of the tracking protection notification, given the right screen dimensions.
[Describe test coverage new/current, TreeHerder]: try server and has been on nightly for a while now.
[Risks and why]: none that I can see
[String/UUID change made/needed]: N/A

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8651047 [details]
MozReview Request: Bug 1196254 - Contextual hint shown the first time tracking protection is triggered is cut off in landscape r?sebastian

Polish a new feature, taking it.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7703f7784afd