Closed Bug 1196254 Opened 8 years ago Closed 8 years ago

Contextual hint shown the first time tracking protection is triggered is cut off in landscape

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
43 Branch
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 fixed, firefox43 verified)

Status:
RESOLVED FIXED
Milestone:
Firefox 43
Tracking Flags:
Tracking Status
firefox42 --- fixed
firefox43 --- verified

People

(Reporter: TeoVermesan, Assigned: mhaigh)

References

Details

Attachments

(3 files)

Hi7LugL.png
28.99 KB, image/png
Details
MozReview Request: Bug 1196254 - Contextual hint shown the first time tracking protection is triggered is cut off in landscape r?sebastian
40 bytes, text/x-review-board-request
sebastian
: review+
Sylvestre
: approval-mozilla-aurora+
Details
PBzVCJX.png
26.85 KB, image/png
Details
Attached image Hi7LugL.png — 
Tested with:
Device: HTC Desire HD (Android 2.3.5) , Samsung galaxy R (Android 2.3.4)
Steps to reproduce:
1. Open private browsing in landscape
2. Go to https://espn.go.com

Expected results:
- A doorhanger is correctly displayed with information about what tracking protection means.

Actual results:
- The doorhanger is cut off in landscape. "Got it" button is not visible

Note:
- Tested with a Samsung S5 (Android 4.4): http://i.imgur.com/eFoixuw.png
Assignee: nobody → mhaigh
Status: NEW → ASSIGNED
Bug 1196254 - Contextual hint shown the first time tracking protection is triggered is cut off in landscape r?sebastian
Attachment #8651047 - Flags: review?(s.kaspari)
Comment on attachment 8651047 [details]
MozReview Request: Bug 1196254 - Contextual hint shown the first time tracking protection is triggered is cut off in landscape r?sebastian

https://reviewboard.mozilla.org/r/16829/#review15151

Ship It!
Attachment #8651047 - Flags: review?(s.kaspari) → review+
url:        https://hg.mozilla.org/integration/fx-team/rev/aec72f4f3fa82e6e57da1e16a93d38ff33b659a9
changeset:  aec72f4f3fa82e6e57da1e16a93d38ff33b659a9
user:       Martyn Haigh <mhaigh@mozilla.org>
date:       Fri Aug 21 15:55:34 2015 +0100
description:
Bug 1196254 - Contextual hint shown the first time tracking protection is triggered is cut off in landscape r=sebastian
https://hg.mozilla.org/mozilla-central/rev/aec72f4f3fa8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Attached image PBzVCJX.png — 
verified as fixed using:
Device: HTC Desire HD (Android 2.3.5)
Build: Firefox for Android 43.0a1 (2015-09-02)
Should we uplift this to 42?
Blocks: tp-v1
Flags: needinfo?(mhaigh)
Comment on attachment 8651047 [details]
MozReview Request: Bug 1196254 - Contextual hint shown the first time tracking protection is triggered is cut off in landscape r?sebastian

Approval Request Comment
[Feature/regressing bug #]: 1175970
[User impact if declined]: Some users may not see all of the tracking protection notification, given the right screen dimensions.
[Describe test coverage new/current, TreeHerder]: try server and has been on nightly for a while now.
[Risks and why]: none that I can see
[String/UUID change made/needed]: N/A
Flags: needinfo?(mhaigh)
Attachment #8651047 - Flags: approval-mozilla-aurora?
Comment on attachment 8651047 [details]
MozReview Request: Bug 1196254 - Contextual hint shown the first time tracking protection is triggered is cut off in landscape r?sebastian

Polish a new feature, taking it.
Attachment #8651047 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.