1196256 - Remove exclude_signup from FxA URLs

Status: RESOLVED DUPLICATE of bug 1167010

(Firefox for iOS :: Sync, defect)

Description

[Richard Newman [:rnewman]]

We can do this once we're confident in blank server Sync client behavior.

Ryan, did you also end up excluding signup for the ios_v1 context? If so, we'll need to roll that back at some point.

Comment 1

[Ryan Kelly [:rfkelly]]

> Ryan, did you also end up excluding signup for the ios_v1 context?

Yes.  We'll need to change some behaviour on the FxA side to allow you to opt back in to the signup experience.  Some options are in https://github.com/mozilla/fxa-content-server/issues/2950 which I'll make sure we've got on our agenda for the next iteration.

Comment 2

[Ryan Kelly [:rfkelly]]

In [1] we changed the logic so that *both* context=fx_ios_v1 and exclude_signup=1 are required to get the no-signups behaviour:

    accounts.firefox.com/signin?context=fx_ios_v1                     -> sign-up link is shown
    accounts.firefox.com/signin?context=fx_ios_v1&exclude_signup=1    -> sign-up link is hidden

This should get released to production with FxA train-45, in approximately two weeks from now.  It'll be on latest.dev.lcip.org shortly.

IIUC, this should be enough to unblock the issue here, let you experiment with building the signup flow in dev, and then enable it globally when you're ready.  On the FxA side, we just need a follow-up bug to let us know when we can remove support for exclude_signup=1 completely, after sufficient penetration of a signup-enabled Firefox for iOS.

Comment 3

[Ryan Kelly [:rfkelly]]

Adding Shane for context.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

(In reply to Ryan Kelly [:rfkelly] from comment #2)
> This should get released to production with FxA train-45, in approximately
> two weeks from now.  It'll be on latest.dev.lcip.org shortly.

Ryan, just checking in to find out if this did indeed land.

 S.

Comment 5

[Ryan Kelly [:rfkelly]]

yes it did [1] and should be available in production for you to try out.

[1] https://github.com/mozilla/fxa-content-server/pull/3028

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/1120

This patch removes the exclude_signup=1 parameter from the FxA production URLs.

This is related to https://github.com/mozilla/firefox-ios/pull/1115 which handles initialization of the sync server in case of account creation. That is about to land and this should go with it so that we can test account creation as soon as possible.

:rnewman, if you review :nalexander's patch, feel free to land this too in one go.

Comment 7

[Richard Newman [:rnewman]]

Comment on attachment 8669493 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1120

Yupyup, a patch to do this is already nesting half-way through Nick's big patch stack (with the wrong bug number).

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Duping this to bug 1167010