Closed
Bug 1196301
Opened 9 years ago
Closed 9 years ago
Add-ons manager should check for the presence of install.rdf first when deciding what kind of add-on it is loading
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla43
People
(Reporter: mossop, Assigned: rhelmer)
References
Details
Attachments
(1 file)
40 bytes,
text/x-review-board-request
|
mossop
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details |
Since add-ons may have manifest.json already present when they want to be regular add-ons we should check for the presence of install.rdf first. Rob, do you want to take this?
Reporter | ||
Comment 1•9 years ago
|
||
[Tracking Requested - why for this release]: This might be breaking some extensions or at least making extension developer's lives harder in 42.
status-firefox42:
--- → affected
tracking-firefox42:
--- → ?
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8650080 -
Flags: review?(dtownsend)
Reporter | ||
Updated•9 years ago
|
Attachment #8650080 -
Flags: review?(dtownsend) → review+
Comment 3•9 years ago
|
||
I can confirm that this patch prevents the problem in bug 1195353
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to 4mr.minj from comment #3) > I can confirm that this patch prevents the problem in bug 1195353 Thanks for testing!
Keywords: checkin-needed
Comment 5•9 years ago
|
||
rhelmer: you broke MozReview. How did you add the patch in comment #2 to MozReview?
Flags: needinfo?(rhelmer)
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #5) > rhelmer: you broke MozReview. How did you add the patch in comment #2 to > MozReview? The patch was uploaded via the web UI (https://reviewboard.mozilla.org/r/new/)
Flags: needinfo?(rhelmer)
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Robert Helmer [:rhelmer] from comment #6) > (In reply to Gregory Szorc [:gps] from comment #5) > > rhelmer: you broke MozReview. How did you add the patch in comment #2 to > > MozReview? > > The patch was uploaded via the web UI > (https://reviewboard.mozilla.org/r/new/) Spoke with gps in IRC, this is the reason the integration didn't work ^ I've got the hg plugin set up now and will just use that in the future. The patch is ready for checkin.
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•9 years ago
|
||
Reopening until this is landed on m-c.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/08d74cb1c447
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment 11•9 years ago
|
||
Is this going to be backported to FF42?
Reporter | ||
Comment 12•9 years ago
|
||
(In reply to 4mr.minj from comment #11) > Is this going to be backported to FF42? Yes, just waiting on some testing on trunk before making the request.
Reporter | ||
Comment 14•9 years ago
|
||
Comment on attachment 8650080 [details] prefer install.rdf over manifest.json Approval Request Comment [Feature/regressing bug #]: Bug 1190692 [User impact if declined]: Some add-ons may appear to be corrupt [Describe test coverage new/current, TreeHerder]: On mozilla-central for a week, good automated tests [Risks and why]: Very low risk a simple code change with good tests [String/UUID change made/needed]: None
Attachment #8650080 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8650080 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•