1196301 - Add-ons manager should check for the presence of install.rdf first when deciding what kind of add-on it is loading

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

Since add-ons may have manifest.json already present when they want to be regular add-ons we should check for the presence of install.rdf first.

Rob, do you want to take this?

Comment 1

[Dave Townsend [:mossop]]

[Tracking Requested - why for this release]:

This might be breaking some extensions or at least making extension developer's lives harder in 42.

Comment 2

[Robert Helmer [:rhelmer]]

Attachment: prefer install.rdf over manifest.json

Comment 3

[Mindaugas <LA-MJ>]

I can confirm that this patch prevents the problem in bug 1195353

Comment 4

[Robert Helmer [:rhelmer]]

(In reply to 4mr.minj from comment #3)
> I can confirm that this patch prevents the problem in bug 1195353

Thanks for testing!

Comment 5

[Gregory Szorc [:gps]]

rhelmer: you broke MozReview. How did you add the patch in comment #2 to MozReview?

Comment 6

[Robert Helmer [:rhelmer]]

(In reply to Gregory Szorc [:gps] from comment #5)
> rhelmer: you broke MozReview. How did you add the patch in comment #2 to
> MozReview?

The patch was uploaded via the web UI (https://reviewboard.mozilla.org/r/new/)

Comment 7

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #6)
> (In reply to Gregory Szorc [:gps] from comment #5)
> > rhelmer: you broke MozReview. How did you add the patch in comment #2 to
> > MozReview?
> 
> The patch was uploaded via the web UI
> (https://reviewboard.mozilla.org/r/new/)

Spoke with gps in IRC, this is the reason the integration didn't work ^ I've got the hg plugin set up now and will just use that in the future.

The patch is ready for checkin.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/08d74cb1c447

Comment 9

[Robert Helmer [:rhelmer]]

Reopening until this is landed on m-c.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/08d74cb1c447

Comment 11

[Mindaugas <LA-MJ>]

Is this going to be backported to FF42?

Comment 12

[Dave Townsend [:mossop]]

(In reply to 4mr.minj from comment #11)
> Is this going to be backported to FF42?

Yes, just waiting on some testing on trunk before making the request.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Tracking to make sure we have it in 42.

Comment 14

[Dave Townsend [:mossop]]

Comment on attachment 8650080 [details]
prefer install.rdf over manifest.json

Approval Request Comment
[Feature/regressing bug #]: Bug 1190692
[User impact if declined]: Some add-ons may appear to be corrupt
[Describe test coverage new/current, TreeHerder]: On mozilla-central for a week, good automated tests
[Risks and why]: Very low risk a simple code change with good tests
[String/UUID change made/needed]: None

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cb6d298f3fe7