1196327 - Toast background is the same color as the tabs tray background

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Jonathan Almeida [:jonalmeida]]

Attachment: Screenshot_of_the_issue.png

Now that the tabs tray is expanded to extend to the full screen, when a tab is closed, the toast that notifies the user about this has the same background color as the tabs tray so it looks a bit odd. (See attached screenshot)

STR:
1. Open Tabs Tray
2. Swipe away a tab
3. Notice the toast that opens up after that.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Anthony, thoughts?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Yeah we should fix this. 

What's the current variables for the toast? I know we set a color and I think a transparency? I can provide new values.

Comment 3

[Jonathan Almeida [:jonalmeida]]

Background: #DD363B40
Button background: #00000000
Button pressed: #DD2C3136
Button Text: #FFFFFFFF

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Chenxia reminded me of bug 1019318 where we set the opacity to "85%" (can you double check this is the case still?) so if we keep this but change #363B40 to #222222, it should be fine.

Can I see a build/screenshot to be sure?

Let's make sure we dont just change the toast here though, but instead, keep it consistent everywhere in our product.

Comment 5

[Jonathan Almeida [:jonalmeida]]

Attachment: comparison.png

Looks good to me!

Yes, we are using 85% opacity. So I just changed the value to 222222.

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Awesome, for the record. #222222 is from our palette too (Placeholder active grey).

Comment 7

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Thanks Jon!

Comment 8

[Jonathan Almeida [:jonalmeida]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b09d552a65f

Comment 9

[Jonathan Almeida [:jonalmeida]]

Attachment: MozReview Request: Bug 1196327 - Toast background is the same color as the tabs tray background r?mcomella

Bug 1196327 - Toast background is the same color as the tabs tray background r?mcomella

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8650853 [details]
MozReview Request: Bug 1196327 - Toast background is the same color as the tabs tray background r?mcomella

https://reviewboard.mozilla.org/r/16785/#review14999

Ship It!

::: mobile/android/base/resources/values/colors.xml:134
(Diff revision 1)
> -  <color name="toast_background">#DD363B40</color>
> +  <color name="toast_background">#DD222222</color>

Feel a bit funny that we're not using the palette here but since the alpha is embedded in the color, I'm not sure what do about that.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/82dfdf972c19

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/82dfdf972c19

Comment 13

[u549602]

Verified as fixed on latest Nightly