1196379 - MOZ_ASSERT "shouldn't find rule in mMatchingRules that is not in aRules"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I hit the assertion at http://hg.mozilla.org/mozilla-central/annotate/d590b9601ba8/layout/style/CSSStyleSheet.cpp#l384 by installing ABP and then logging into Netflix in the same browser session.  Will attach gdb session logs.  I was not able to reproduce.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: gdb session

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I was able to reproduce this reliably by installing ABP and then visiting this page:
http://simple-adblock.com/faq/testing-your-adblocker/
I hit the assertion every time.

Comment 3

[Cameron McCormack (:heycam)]

Thanks Bill, I hit the assertion with that page too.

Comment 4

[Daniel Holbert [:dholbert]]

(I hit this when restoring a gmail tab in a debug build, too, FWIW.)

Comment 5

[Cameron McCormack (:heycam)]

Attachment: patch

The assertion is wrong.  It should have been checking that that was the state after finishing the loop advancing pm.  Let's rewrite the assertion to be more clear about what it should be checking.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/48aa6b41ecd3

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/48aa6b41ecd3