Closed Bug 1196381 Opened 4 years ago Closed 4 years ago

Rip out code that uses Breakpad in ThreadStackHelper

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: jchen, Unassigned)

References

Details

Attachments

(1 file)

No description provided.
The breakpad dependency in ThreadStackHelper is preventing us from
upgrading our in-tree copy to a newer version (bug 1069556). This patch
gets rid of that dependency. This makes native stack frames not work
for BHR, but because of the ftp.m.o decommissioning, native
symbolication was already broken and naive stack frames already don't
work, so we don't really lose anything from this patch.

Eventually we want to make ThreadStackHelper use other means of
unwinding, such as LUL for Linux

I added | #if 0 | around the code to fill the thread context, but left
the code in because I think we'll evenually want to reuse some of that
code.
Attachment #8661471 - Flags: review?(snorp)
Attachment #8661471 - Flags: review?(nfroyd)
Comment on attachment 8661471 [details] [diff] [review]
Eliminate breakpad dependency in ThreadStackHelper (v1)

Review of attachment 8661471 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8661471 - Flags: review?(nfroyd) → review+
Comment on attachment 8661471 [details] [diff] [review]
Eliminate breakpad dependency in ThreadStackHelper (v1)

Review of attachment 8661471 [details] [diff] [review]:
-----------------------------------------------------------------

:(
Attachment #8661471 - Flags: review?(snorp) → review+
https://hg.mozilla.org/mozilla-central/rev/5e86358d4ec2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
I noticed that this #if 0 code is still in the tree a year later, and I don't see any followup bugs started from this one. Is there any reason to keep this code around?
You need to log in before you can comment on or make changes to this bug.