1196381 - Rip out code that uses Breakpad in ThreadStackHelper

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Eliminate breakpad dependency in ThreadStackHelper (v1)

The breakpad dependency in ThreadStackHelper is preventing us from
upgrading our in-tree copy to a newer version (bug 1069556). This patch
gets rid of that dependency. This makes native stack frames not work
for BHR, but because of the ftp.m.o decommissioning, native
symbolication was already broken and naive stack frames already don't
work, so we don't really lose anything from this patch.

Eventually we want to make ThreadStackHelper use other means of
unwinding, such as LUL for Linux

I added | #if 0 | around the code to fill the thread context, but left
the code in because I think we'll evenually want to reuse some of that
code.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8661471 [details] [diff] [review]
Eliminate breakpad dependency in ThreadStackHelper (v1)

Review of attachment 8661471 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8661471 [details] [diff] [review]
Eliminate breakpad dependency in ThreadStackHelper (v1)

Review of attachment 8661471 [details] [diff] [review]:
-----------------------------------------------------------------

:(

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e86358d4ec2

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5e86358d4ec2

Comment 6

[(Away)]

I noticed that this #if 0 code is still in the tree a year later, and I don't see any followup bugs started from this one. Is there any reason to keep this code around?