1196455 - Can not set absolute alarm that is before the event starts

Status: RESOLVED FIXED

(Calendar :: Provider: GData, defect, P1)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Looks like there is a sign error somewhere. The "...only allows reminders up to 4 weeks before the event starts" shows up when setting an absolute reminder that is before the event starts. The message goes away when you set the absolute date to after the event starts.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 3

[[:MakeMyDay]]

Comment on attachment 8660489 [details] [diff] [review]
Fix - v1

Review of attachment 8660489 [details] [diff] [review]:
-----------------------------------------------------------------

r+, but please check the comment below.

::: calendar/test/unit/test_alarmutils.js
@@ +193,5 @@
> +    alarm.related = alarm.ALARM_RELATED_ABSOLUTE;
> +    alarm.alarmDate = cal.createDateTime("20150815T110000");
> +    equal(calculateAlarmOffset(alarm).icalString, "-PT1H");
> +    equal(calculateAlarmOffset(alarm, alarm.ALARM_RELATED_START).icalString, "-PT1H");
> +    equal(calculateAlarmOffset(alarm, alarm.ALARM_RELATED_END).icalString, "-PT2H");

Why do you test this block twice - it's the same as above?

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

Good catch. I've also removed the window dump pref that was there for debugging.

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/4ab843365b56a3aaa4e21d25e8ba1ef072421014
Bug 1196455 - Can not set absolute alarm that is before the event starts. r=MakeMyDay a=aleth