Closed Bug 119659 Opened 24 years ago Closed 24 years ago

Can't see hebrew with latest build

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: barakedry, Assigned: shanjian)

References

(
URL
)

Details

Attachments

(3 files)

Debugging patch
674 bytes, patch
Details | Diff | Splinter Review
Screenshot of the problem
113.51 KB, image/jpeg
Details
patch
1.10 KB, patch
smontagu
: review+
attinasi
: superreview+
dbaron
: approval+
Details | Diff | Splinter Review
From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.7+) Gecko/20020109 BuildID: 20020111 Latest 20020111 build doesn't render hebrew at all using winxp pro. Everything worked grate with 2002010903 build. I'll attach screenshot of the problem as soon this bug will be Confirm as New. Reproducible: Always Steps to Reproduce: 1.Enter any hebrew site like www.walla.co.il 2. 3. Actual Results: Mozilla shows gibberish instad of hebrew characters Expected Results: Render hebrew correctly like with 20020109 build.
You sure you didn't set something strange in View | Character Coding?
I'm sure i didn't. All hebrew related Character Coding preduce the same result. i Also know the problem exist on my friend's comp which also runs winxp.
wfm 2001122106 -- WinME
>I'll attach screenshot of the problem as soon this bug will be Confirm as New. Please attach the screenshot already.
shanjian, can you check whether this was caused by your recent changes to nsFontMetricsWin.cpp? I found when debugging that I could eliminate the problem by forcing all calls to nsRenderingContextWin::DrawString to go through ResolveForwards instead of ResolveBackwards.
Assignee: mkaply → shanjian
Severity: major → critical
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 119848 has been marked as a duplicate of this bug. ***
I know what is the problem. I will fix it after bug 118000 get in.
Status: NEW → ASSIGNED
Attached patch patch — — Splinter Review
simon, Could you try my patch to make sure it works? If so, please r=. Thanks!
Comment on attachment 65142 [details] [diff] [review] patch Tested a number of Hebrew Arabic and Persian sites with different encodings, and everything looks OK. r=smontagu
Attachment #65142 - Flags: review+
*** Bug 120343 has been marked as a duplicate of this bug. ***
Marc, could you sr this one?
Comment on attachment 65142 [details] [diff] [review] patch sr=attinasi
Attachment #65142 - Flags: superreview+
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Keywords: mozilla0.9.8+
Resolution: --- → FIXED
added back keyword I accidentally removed.
Keywords: mozilla0.9.8+
verified on latest mozilla builds: windows 2002-02-14-09-trunk linux 2002-02-14-08-trunk mac osx 2002-02-14-08-trunk
Status: RESOLVED → VERIFIED
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: zach → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: